Anna Buianova
|
20e242af0d
|
Rubocop fixes (#20254)
* Fixed redundant alls for rubocop
* Fixed rubocop violations in spec/requests
* Fixed rubocop violations in spec/models
* Fixed Performance/MapMethodChain
* Fixed rubocop violations in spec/requests
* Revert changes to FastlyConfig::Update spec
|
2023-10-18 17:24:28 -04:00 |
|
Mac Siri
|
842e6880b8
|
Routine rubocop fix on /spec (#19217)
* Softrun rubocop
* Hardrun rubocop (-A)
* Change a rubocop rule
* Add missing cops
* Undo & redo rubocop -A
|
2023-03-21 09:55:26 -04:00 |
|
Mac Siri
|
9be5c8c6b0
|
Routine Rubocop fixes (#16838)
|
2022-03-09 09:32:50 -05:00 |
|
Anna Buianova
|
4cab190285
|
Hiding comments: an option to hide or keep children (#15178)
* Optional hiding child comments (start)
* Changed confirm button in comments hide form
* Hide children comments if hide_children was passed
* Added a spec for hidden child comment notifications
* Hide only explicitly hidden comments
* Hide comment modal on article page
* Prevent default behaviour for hide comment link
* Improved hide comments modal looks
* Improved hide comments modal looks
* Removed unused code
* Send hide comment form via fetch
* Hide comment descendants when hide_children was passed
* Don't hide hidden comments descendants on permalink
* Removed unnecesary span
* Improved hide comments modal styling
* Removed unused styles and js, improved styling
* Clickable label
Co-authored-by: ludwiczakpawel <ludwiczakpawel@gmail.com>
* Fixed showing hidden comments spoiler for article author
* Fixed hideArticleComments.spec.js
* Fixed displaying hidden comments text for artice author, added specs
* Target hide comments modal inside the modal when adding a listener
Co-authored-by: Suzanne Aitchison <suzanne@forem.com>
* Replaced hide comment link with a button
* Refactored adding hide_children url param
Co-authored-by: Suzanne Aitchison <suzanne@forem.com>
* Fixed cypress hide comments test
* Removed aria-label for submit on the hide comments modal
* Fixed formatting
Co-authored-by: ludwiczakpawel <ludwiczakpawel@gmail.com>
Co-authored-by: Suzanne Aitchison <suzanne@forem.com>
|
2021-11-18 11:57:40 +03:00 |
|
Molly Struve
|
5d22e71ad6
|
nothing to see here....except maybe reverting a push to master (#8308)
🙈
|
2020-06-05 20:34:21 -05:00 |
|
mstruve
|
533cab50d6
|
synchronous roles
|
2020-06-05 20:02:41 -05:00 |
|
rhymes
|
f3c2adfa45
|
Routine rubocop fixes (#6138)
|
2020-02-18 11:21:42 -05:00 |
|
Andy Zhao
|
71157c993e
|
Hide comment feature (#4944)
* Add MVP of hide comment feature
* Slight copy adjustments
* Remove unused file oops
* Fix strange styling issues
* Add hide/unhide comment specs
* Authenticate user for hide/unhide
* Add tests for hide/unhide functionality
* Remove opacity CSS for hidden comments
* Fix hidden comment explanation logic
* Fix some styling issues
* Fix hiding top level comment logic
* Show only hidden comments in permalink and not thread
* Hide subtree properly if hidden comment
* Fix weird CSS issue
* Properly hide comments for permalink view
* Show children comments in permalink view
* Add tests for comment hiding visibility
* Remove superfluous code and adjust copy
* Remove some more logical duplication
* Add dedicated article column for any comments hidden
* Add reload in test
|
2019-12-10 15:09:47 -05:00 |
|
Mac Siri
|
d976eb7ab6
|
Create InternalPolicy (#4380)
* Ensure verify_authorized in internal
* Create internal_policy
* Replace ArticlePolicy usage with InternalPolicy
* Replace BufferUpdate&CommentPolicy with InternalPolicy
* Remove verbose authorize_admin
* Forgot to remove coresponding specs
* Create specs for InternalPolicy
* Expand policy access on internal's broadcast
* Refactor
* Create shared spec
* Create request specs
* Add additional test cases
|
2019-10-17 14:21:43 -04:00 |
|