Arit Amana
41acd673d0
Make Follow Buttons in User, Org and Tag Embeds "secondary" ( #17602 )
...
* complete implementation
* Make PR review changes
2022-05-10 16:37:39 -04:00
Jeremy Friesen
a65954107f
Refactoring to add helper method ( #16064 )
...
* Refactoring to add helper method
Prior to this commit, we made view level calls to service modules. This
refactor provides convenience methods on the model.
Furthermore, it addresses a few Rubocop violations that "come along for
the ride."
* Ensuring cached entity squaks like User
* Fixing broken spec
* Fixing typo
2022-01-12 11:21:44 -05:00
Keshav Biswa
42c9a10f57
Accessible names for follow buttons ( #14389 )
...
* added follow hidden tags for accessibility
* fixed failing tests
* replaced hidden span with screen-reader-only with aria-label
* add aria-label dynamically to follow buttons
* fixed followButtons
* fixed cypress tests and updated addAriaLabelToButton helper
* Fixed failing tests
* fixed failing tests
* Update cypress/integration/seededFlows/notificationsFlows/followUserFromNotifications.spec.js
Co-authored-by: Suzanne Aitchison <suzanne@forem.com>
Co-authored-by: Suzanne Aitchison <suzanne@forem.com>
2021-09-07 16:09:06 +01:00
Mac Siri
9ebd742712
[deploy] Reintroduce sticky_nav changes ( ab81f36 & 7f92855) ( #10263 )
...
* Revert "[deploy] Revert removal of unneeded eager load (if needed) (#10179 )"
This reverts commit 11c7b148da#10055 )" (#10149 )"
This reverts commit 5657067e55
2020-09-09 15:33:13 -04:00
Molly Struve
5657067e55
[deploy] Revert "Migrate ProfileImage to Images::Profile ( #10055 )" ( #10149 )
...
This reverts commit ab81f36a38
2020-09-01 18:28:58 -05:00
Mac Siri
ab81f36a38
[deploy] Migrate ProfileImage to Images::Profile ( #10055 )
2020-09-01 17:16:03 -04:00
Michael Kohl
79f1f5f0c8
Change string concatenation to interpolation ( #7680 )
...
* Change string concatenation to interpolation
* Replace more concatenation with interpolation
* Add forgotten interpolation
2020-05-06 17:13:10 +02:00
Sebastien
665f5aac0f
Refactor ProfileImage ( #5803 )
2020-02-07 08:56:16 -05:00
Ben Halpern
d55a392bed
Add organization liquid tag ( #3203 )
2019-06-17 13:47:42 -04:00
