maverick/docbrown
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
7349 commits 1 branch 0 tags 1.6 GiB
Commit graph

415 commits

Author SHA1 Message Date
Arit Amana
08796b5cee
[Team Email Login] Refactor Authentication Provider Enable/Disable (#11185) 
* Starting out

* Building away...

* Hooking buttons up

* Hook Auth Provider buttons to Array Field

* trying to fix NoNameError

* Remains InviteOnlyMode disable and tests

* Smashing remaining tasks

* Last of tasks

* add tests

* Complete specs and tests 😅

* Fix bug

* Additional guard

* pass event to functions

* Position Email Auth first

* Fix bug in Email Auth Modal

* Fix spacing issue

* Update docs for adminModal.js

* Show/hide Enabled Indicator with Enable/Undo buttons

* Complete Auth Providers functionality

* Update app/javascript/admin/controllers/config_controller.js

Co-authored-by: Vaidehi Joshi <vaidehi.sj@gmail.com>

* Update app/javascript/admin/controllers/config_controller.js

Co-authored-by: Vaidehi Joshi <vaidehi.sj@gmail.com>

* Update app/controllers/admin/configs_controller.rb

Co-authored-by: Vaidehi Joshi <vaidehi.sj@gmail.com>

* Update helper names

* better implementation of EnabledIndicator show/hide

* Small copy changes

* Update spec/helpers/authentication_helper_spec.rb

Co-authored-by: Vaidehi Joshi <vaidehi.sj@gmail.com>

* Update app/views/admin/configs/show.html.erb

Co-authored-by: Vaidehi Joshi <vaidehi.sj@gmail.com>

* Update app/helpers/authentication_helper.rb

Co-authored-by: Vaidehi Joshi <vaidehi.sj@gmail.com>

Co-authored-by: Vaidehi Joshi <vaidehi.sj@gmail.com>
 2020-11-06 18:19:34 -05:00
Fernando Valverde
f11523f29a
Makes Runtime.js detect the generalized ForemWebView User Agent (#11288) 
* Makes Runtime.js detect the generalized ForemWebView User Agent extension

* Adds tests
 2020-11-05 14:18:17 -06:00
Josh Puetz
542ee58ab8
Rate Limit Modal - Comments (#11102) 
* Non-preact modal

* Some cleanup

* Toggle modal on navigation

* Use rate limit modal on comments page

* Added JSdocs

* Remove explanation link

* Comment rate limit test

* Tests and method renaming
 2020-11-03 15:49:20 -06:00
ludwiczakpawel
5d3691bcc5
Notifications redesign (#11084) 
* notifications

* fix

* .

* REVERT

* .

* drop ccss

* REVERT

* specs

* drop colons

* fixse

* fix

* spec 1

* eh

* Fix notification specs

Co-authored-by: Molly Struve <mollylbs@gmail.com>
 2020-10-29 20:38:17 +01:00
ludwiczakpawel
1636bdf4c8
Autoresize on comment textarea + comment submit on CMD/CTRL+Return (#11115) 
* .

* whoops

* revert typo

* Handle glitches and edge cases.

Co-authored-by: Ben Halpern <bendhalpern@gmail.com>
 2020-10-29 09:33:11 +01:00
Ben Halpern
531f26bad6
Add admin shortcut to tag page (#11092) 
* Add admin shortcut to tag page

* Fix spec

* Add more check

* Change admin location
 2020-10-28 12:19:21 -04:00
Robin Gagnon
10d7da2878
feat: Add shortcut to bookmark an article (#11116) 2020-10-27 12:44:03 -04:00
Molly Struve
dbfed77f37
Flaky Spec Fix:Remove js:true From Local Timestamp Checks and js Fix attempt code (#11087) 2020-10-26 10:20:51 -05:00
Molly Struve
4a394f1b96
[deploy] Bug Fix:Only Require Timemachine for Testing envs (#11085) 2020-10-26 08:57:16 -05:00
Molly Struve
3884009f08
Spec Fix:Set Javascript Locale to Match Time.zone (#11025) 2020-10-26 07:51:32 -05:00
Ben Halpern
6fac74b741
[deploy] Experiment with the removal of inline critical path css (#11027) 
* Experiment with the removal of inline critical path css

* Fix up tests, remove reference to deleted file

* Change docs

* Fix typo
 2020-10-22 19:22:28 -04:00
Elliot
6a1f560f65
[deploy] Fix dropdowns breaking after adding comment (#10976) 
What was wrong?
`initializeCommentDropdown` is called when a new comment is added.
`initializeCommentDropdown` calls `addDropdownListener(dropdown)` on all
`.dropbtn` elements. Elements with the `.dropbtn` class already exist on
the page so an extra listener is added to it whenever a comment is
added.

How was it fixed?
Whenever a dropdown listener is added to an element with the
`.dropbtn` class, an attribute is set on that element so we know it
already has a dropdown listener. When we add listeners to elements with
the `.dropbtn` class in the future, we don't add them to elements with
the attribute.
 2020-10-21 08:15:10 -04:00
Ben Halpern
467e99556c
[deploy] Fix tag display bug and crayonsify area (#10868) 
* Fix tag display bug and crayonsify

* Fix some specs

* Remove unused tag js

* Adjust to remove crayons card bg

* Adjust padding

* add spacing below nav

* drop unnecessary classname

* cleanup headers

* links

* Finalize style and add hint to eliminate div jump

Co-authored-by: ludwiczakpawel <ludwiczakpawel@gmail.com>
 2020-10-20 16:07:17 -04:00
ludwiczakpawel
95619a9c92
Adding admin link for admins (#10926) 
* adding admin link for admins

* ok, workaround
 2020-10-19 12:44:17 -04:00
Akshay Mahajan
ff918daa20
Remove flare tag from title and hightlight it within the tags row (#10528) 
* Remove flare tag from title and hightlight it within the tags row

* wrap flare tag # in a span with class crayons-tag__prefix

* updated buildArticleHTML.js to show flare tag in the tags row

* updated _single_story.html.erb to show flare tag in the tags row

* fixed missing opening tag

* removed crayons-story__flare-tag class and containers

* added .crayons-story__flare-tag back to stories.scss for search results

* added check for undefined tagList in buildArticleHTML.js
 2020-10-15 16:09:14 +02:00
Rafi
0d2b4c515d
Replace globals with node env (#10767) 2020-10-14 17:05:38 -04:00
Andrew Bone
b37b633b35
[deploy] Add scroll to Anchor (#10464) 
* Add scroll to Anchor

* Fix code typos

* Move to template litterals
 2020-10-07 12:55:57 -05:00
Ben Halpern
c60566b8a5
[deploy] Modify code to deal with flaky tests (#10616) 
* Modify code to deal with flaky tests

* Remove uneeded x
 2020-10-05 14:54:11 -04:00
Ben Halpern
c0d5486023
[deploy] Fix current_user cache issue in comments (#10609) 2020-10-05 10:52:12 -04:00
ludwiczakpawel
1375e8a4df
[deploy] Redesigned Comment Form (#10355) 
* init

* .

* .

* better

* last bits

* specs

* merge

* fix response templates for replies

* copy

* active inactive buttons + cleanup

* labels

* specs

* specs

* response templates fix

* ....

* wtf

* .
 2020-10-05 12:01:48 +02:00
ludwiczakpawel
9d384e1a93
CSS Cleanups, part 2 (#10527) 
* padding-top on body

* padding-top on body

* move cheese around

* .

* :(

* rename
 2020-10-03 06:57:57 +02:00
Robin Gagnon
87590e77d3
[deploy] feat: Disable autoplay on native videos (#10516) 2020-10-01 16:52:12 -06:00
Mac Siri
02bd3111af
[deploy] Refactor: Create setCurrentUserToNavBar (#10501) 2020-09-30 16:20:23 -04:00
narender2031
649c23f854
add no console rule front-end (#10362) 
* add no console rule front-end

* add no-console to root eslintrc

* disbale no console rule

* remove console
 2020-09-29 09:56:37 +02:00
Fernando Valverde
b5309c4a21
[deploy] User agent check fix for native iOS (#10472) 2020-09-28 14:45:36 -04:00
Molly Struve
6193ceeace
[deploy] Refactor: Cleanup Frontend Code (#10466) 2020-09-28 08:57:34 -05:00
ludwiczakpawel
3e9b56a7dd
[deploy] Frontend cleanups (#10416) 2020-09-24 08:15:12 -05:00
ludwiczakpawel
4bf69e64c5
Update search menu to use Crayons styling, v2 (#10347) 
* Replace old query style with crayons link block

* Add Crayons layout

* Rename nav file and refactor how it's referenced in parent file

* Rename sidebar file

* style updates

* more changes

* podcasts

* .

* code format

Co-authored-by: Lisa Sy <lisasyis@gmail.com>
 2020-09-16 22:03:34 +02:00
Ben Halpern
3e09a7768f
[deploy] Remove need for ENV vars during asset precompile (#10349) 
* Remove need for ENV vars during asset precompile

* Add open-search test
 2020-09-16 13:57:05 -04:00
Fernando Valverde
1aa8233d9e
Adds runtime copy to clipboard (#10323) 2020-09-14 14:45:54 -04:00
Vaidehi Joshi
abe2489394
Hide active broadcasts from /connect routes (#10312) 
Fixes https://github.com/forem/forem/issues/9683.
Also refactors the initializeBroadcast function to handle all
broadcast-related logic, and removes broadcast checks from the articleForm component.
 2020-09-14 11:28:18 +02:00
Ben Halpern
a1f664ab5b
Fetch GA Tracking ID from SiteConfig (#10262) 2020-09-09 18:17:44 -04:00
Rafi
ea74a3d390
Using global util function for displaying date in listing dashboard (#10244) 
* Common date util function for listing dashboard

* Making dateTime required

* Fixing typo

* Fixing tests

* Fixing deletion of function in globalThis
 2020-09-09 09:35:05 +02:00
ludwiczakpawel
74b398d876
New Profile Header (#10185) 
* init

* profile header

* merge

* two headers

* centerd

* link fix

* remove comments

* whoops

* Fix specs

Co-authored-by: rhymes <rhymes@hey.com>
 2020-09-03 16:47:01 +02:00
Lisa Sy
54c071856e
[deploy] Update top-header for logged-out user (#9874) 
* Create first start at desktop top header updates

* Update mobile styling of top header

* Stylize sign in widget card

* Update nav menu and top bar

* Changes based on user being logged-in or not

* Uses user_signed_in? on top nav bar

* Fix lingering old cloudinary helper method

* Trigger CI

* Fixes specs

* Adds redirect_using_referer_spec, fixes other specs & cleanup

* Adds nav-menu.scss to layouts/_styles.html.erb for inline & small edit in referer check

* Remove logged-out styles to make it more uniform with logged in

* Remove nav-menu.scss file

* cleanup markup and JS a little

* Fixes FB auth specs to new login links

* Makes sure unauthenticated /new redirects back to editor

* CI fix Sing in with -> Continue with

* Update db/schema.rb

* Update db/schema.rb

* Update db/schema.rb

Co-authored-by: Fernando Valverde <fdov88@gmail.com>
Co-authored-by: ludwiczakpawel <ludwiczakpawel@gmail.com>
Co-authored-by: Ben Halpern <bendhalpern@gmail.com>
 2020-08-31 18:12:22 -04:00
Fernando Valverde
9da71a47c7
[deploy] Introduces Runtime class for standardized & other native cleanup + replace podcast GA with ahoy (#10026) 2020-08-28 05:52:04 -06:00
ludwiczakpawel
503b1e3be6
Remove dimmed buttons on feed (#9894) 
* flare tag line height

* .

* dropdown fix + actions bar fix

* actions bar on mob

* fix
 2020-08-26 08:08:31 +02:00
ludwiczakpawel
1776377234
Improve styling for series (#9893) 
* .

* flare tag line height

* .

* series switcher

* .

* revert

* editor preview fix

* Fix broken spec

Co-authored-by: Mac Siri <krairit.siri@gmail.com>
Co-authored-by: rhymes <rhymes@hey.com>
 2020-08-24 09:53:51 +02:00
Lisa Sy
aea5615a8e
Style logged-out authentication modal (#9827) 
* WIP Update modal styling

* Update styles of logged out auth modal

Co-authored-by: Ben Halpern <bendhalpern@gmail.com>
 2020-08-18 17:38:08 +02:00
Andy Zhao
f4b50a11b4
Check for meta payment pointer first before attempting to load (#9722) 2020-08-10 18:12:48 -04:00
ludwiczakpawel
dbbe158d21
Buttons: Ghost Dimmed (#9626) 
* flare tag line height

* .

* dropdown fix + actions bar fix

* actions bar on mob

* ghost dimmed

* add to page/crayons
 2020-08-06 11:03:06 +02:00
Mac Siri
e330298561
[deploy] Update instantClick's script clone logic (#9542) 2020-07-28 09:06:58 -04:00
Fernando Valverde
5d55299ac3
[deploy] Removes intrusive mobile video autoplay & adds ahoy for visibility (#9539) 
* Removes intrusive mobile video autoplay & adds ahoy for visibility

* web video has autoplay enabled

* Implements feedback on video player ahoy events

* use strict equality
 2020-07-27 13:11:40 -06:00
Alberto Pérez de Rada Fiol
e35f4a699d
Don't show badge when reading list is left empty (#9437) 2020-07-22 08:55:33 -04:00
Mac Siri
5e43911f17
[deploy] Update Honeybadger's ignorePatterns (#9420) 2020-07-21 17:15:36 -04:00
Lisa Sy
949b092dbd
[deploy] Update broadcast styling (#9411) 2020-07-20 20:17:53 -04:00
Fernando Valverde
154a3629ee
Add Native bridge video support (#9303) 2020-07-20 11:22:32 -04:00
Pavel Tkachenko
9e94b80741
[deploy] Add local_date helper to handle dates with respect of user timezone (#9285) 
* Add local_date helper to handle dates with respect of user timezone

* Fix date timezone bug for articles/show

* Fix date_helper to meet system specs requirements
 2020-07-16 08:45:44 -06:00
Vaidehi Joshi
2fadc24d28
Fix TypeError: null is not an object in initializeArticleReactions.js (#9297) [deploy] 
* Fix TypeError: null is not an object in initializeArticleReactions.js

Should fix https://app.honeybadger.io/fault/67192/6f9b4fdf475e2229c968fa26d785b90f

* Return 0 rather than undefined if reactionEl doesn't exist
 2020-07-14 08:12:07 -07:00
Vaidehi Joshi
3391593de1
Fix TypeError: userData is null in initializeOnboardingTaskCard.js (#9298) [deploy] 
* Fix TypeError: userData is null in initializeOnboardingTaskCard.js

Should fix https://app.honeybadger.io/fault/67192/65045742fda3390a067960f53a894e87.

* Combine return statements in initializeOnboardingTaskCard
 2020-07-14 07:32:57 -07:00