rhymes
8407bf9b4e
[deploy] Authentication refactoring: cleanups ( #7576 )
...
* Use Devise registry to list available providers
* Cleanups following Devise+Omniauth docs
* More cleanups
* Use helpers
* More cleanups
* Oops, forgot to remove these specs
2020-04-29 10:33:30 -04:00
rhymes
1b93666b3b
[deploy] Add user_id presence validation for Identity ( #7365 )
...
* Add user_id presence validation for Identity
* Remove duplicated validation
* Save user within build_user
* Fix typo
* Fix spec with in memory user
2020-04-17 20:02:26 +02:00
rhymes
d6e47a03c7
[deploy] Authentication refactoring - step 1 ( #7259 )
...
* Add Authentication providers
* Making strides on refactoring
* New usr from Twitter
* Existing Twitter user
* Existing user Github
* Test skip_confirmation!
* Refactor a bit and add simplecov groups
* Test user already logged in
* Rename to Authentication::Authenticator
* Refactor to a common class
* Add existing user test for twitter login
* Refactor global handler
* Fix spec and comment Twitter provider
* Update comments and strategy TODO
* Move providers loading code to Authentication::Providers
* add SubclassResponsibility error
* Use delegation
2020-04-15 12:13:10 -04:00
rhymes
9c05e618db
Improve speed of model tests by around 50/60 seconds ( #5016 )
2019-12-09 16:33:48 -05:00
rhymes
e62f5ada21
Add missing fks to api_secrets, listings and identities ( #4997 ) [deploy]
2019-12-03 10:59:13 -06:00
rhymes
816c062ea0
Upgrade Rubocop related gems and fix new violations ( #3581 ) [ci skip]
2019-07-30 14:29:05 -04:00
Anna Buianova
4b02fe87a4
Optimize sign in: Identity #2061 ( #2231 )
...
* Add unique index to identity
* Conditional uniqueness validations on identities
* Remove redundant Identity specs
2019-03-28 16:10:23 -04:00
Keshav Biswa
8d57d45ecc
Rubocop Style cops enabled ( #2056 )
...
* Rubocop enabled style/alias
* Enabled Style/ArrayJoin Cop
* Enabled Style/Attr
* Enabled Case Equality
* Enabled CharacterLiteral
* Enabled ColonMethodCall Cop
* Enabled CommentAnnotation cop
* Enabled PreferredHashMethods Cop
* Enabled DoubleNegation Cop
* Enabled EachWithObject Cop
* Enabled EmptyLiteral Cop
* Enabled EvenOdd Cop
* Enabled IfWithSemicolon Cop
* Enabled Lambda and LambdaCall Cop
* Enabled LineEndConcatenation Cop
* Enabled ModuleFunction Cop;
* Enable NegatedIf and NegatedWhile Cop
* Enabled NilComparison Cop
* Enabled Not Cop
* Enabled NumericLiterals Cop
* Enabled OneLineConditional Cop
* Enabled PercentLiteralDelimiters Cop
* Excluded internal/users_controller from negated_if cop
* Reverted the double negation change from github_issue_tag and github_issue.rb"
* Enabled PerlBackrefs Cop
* Changed Regexp.last_match(1) to Regexp.last_match(0)
* Enabled proc cop
* Enabled RaiseArgs Cop
* Reverted Regexp.last_match(0) to Regexp.last_match(1)
* Enabled SelfAssignment Cop
* Enabled SingleLineMethods Cop
* Enabled SpecialGlobalVars Cop
* Enabled VariableInterpolation Cop
* Enabled WhenThen Cop
* Enabled WhileUntilModifier Cop
* Enabled WordArray Cop
* Enabled IfUnlessModifier Cop
* Enabled GuardClause Cop
2019-03-15 18:33:54 -04:00
Mac Siri
1137d6fba4
Improve specs ( #1693 )
...
* Lock erb_lint
* Refactor moderation spec
* Remove & replace RequestSpecHelper
* Update uid to sequence
* Lower the need for persistence in specs
* Update moderation spec
* Update shoulda-matchers
* Enable backgroundjobs and update commenct spec
* Fix fail specs
* Update comment's validations
* Remove redundent specs
* Actually turn off DJ
* Apply run_background_jobs_immediately
* Remove giveawy specs
* Create Identity spec
2019-02-04 15:56:00 -04:00
