Mac Siri
b77c1ea2e6
Change rake spec setup ( #19012 )
2023-01-30 10:51:38 -05:00
Suzanne Aitchison
f1df37f431
Add "only display when logged out" as an option on Navigation Links ( #18275 )
...
* add new column with enum value
* refactor to use display_to column
* add some more specs to application_helper
* test for the backfill DUS
* fix line length
* refactor
2022-08-08 10:55:24 +01:00
Mac Siri
678dda8cf4
Routine Rubopcop lint fixes ( #17844 )
...
* Routine Rubopcop lint fixes
* Undo app_secrets_spec changes
* Fix broken spec
2022-06-07 10:17:16 -04:00
Suzanne Aitchison
f1864847e7
Make home link an admin-customisable navigation link ( #16268 )
...
* move home link to a customisable navlink
* add trailing slash for path
* update specs
* replace positions, set home link to -1
* add update script for adding home navigation link
* update data update script
2022-02-01 09:27:09 +00:00
Arit Amana
812bfa2bbf
Create Default Nav Links In New Forem (RFC #237 ) ( #14345 )
...
* schema file undelete description
* update with main
* update with origin
* update
* create rake task for new-forem nav links
* remove debugger
* create rake task for new-forem nav links
* remove debugger
* incorporate review feedback
* DRY image paths up
Co-authored-by: Jamie Gaskins <jgaskins@hey.com>
2021-08-02 12:52:36 -04:00
Andy Zhao
0eaea33710
Replace admin guide links ( #13967 )
...
* Replace admin guide links
* Add missing /docs/
* Add proper links
2021-06-23 15:01:01 -04:00
dependabot[bot]
9066de9b65
Bump rubocop-rails from 2.9.1 to 2.10.0 ( #13655 )
...
* Bump rubocop-rails from 2.9.1 to 2.10.0
Bumps [rubocop-rails](https://github.com/rubocop/rubocop-rails ) from 2.9.1 to 2.10.0.
- [Release notes](https://github.com/rubocop/rubocop-rails/releases )
- [Changelog](https://github.com/rubocop/rubocop-rails/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rubocop/rubocop-rails/compare/v2.9.1...v2.10.0 )
Signed-off-by: dependabot[bot] <support@github.com>
* Add new cops and fix violations
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: rhymes <rhymes@hey.com>
2021-05-05 14:16:44 -07:00
Daniel Uber
a31a4cafed
Remove hardcoded "localhost:3000" from metrics spec ( #13561 )
...
When the APP_DOMAIN is not "locahost:3000" then the overview language
does not include localhost:3000. Specifically I was running this test
in a container named "rails" and saw "rails" in place of localhost.
Ran the test both in the container and local/native to confirm this
fixes the one without breaking the other.
2021-04-28 10:50:02 -05:00
Vaidehi Joshi
a5f014f576
[15 Min Fix]: Fix incorrect scope used by metrics:overview rake task ( #13138 )
...
* Fix incorrect scope used by metrics:overview rake task
* Add spec for metrics:overview rake task
* Add guard clause to metrics:overview rake task
2021-03-25 17:31:10 -07:00
Molly Struve
060ed32c48
Refactor:Send Welcome Broadcast Notifications From Sidekiq ( #9923 )
...
* Refactor:Send Welcome Broadcast Notifications From Sidekiq
* remove old spec and add to new one
2020-08-21 12:57:08 -04:00
Molly Struve
b40af82b66
Flaky Spec Fix:Remove let_it_be Test Prof Helper ( #9556 )
...
* Flaky Spec Fix:Remove let_it_be Test Prof Helper
* Spec cleanup and fixes
2020-07-29 11:31:01 +02:00
Alex
7149070bca
[deploy] Create FastlyConfig & refactor params safe list ( #7630 )
...
* Fastly refactor
- Create FastlyConfig
- Create FastlyConfig::Base
- Create FastlyConfig::Snippets
- Move safe_params to its own VCL file
- Rescue unauthorized errors in development
- Add FastlyConfig errors
* Move active version to method
* Update naming option --> config
* Refactor InvalidConfigsFormat msg to Error class
* Refactor active version logic
* Fix log_to_datadog call
* Move get_active_version logic back into method
* Add some specs ¯\_(ツ)_/¯
* Update Fastly rake task
* Remove old Fastly way
* Update docs for Fastly
* Move snippets to config/ & remove old config
* Change update_config to upsert_config
* Change error type to SubclassResponsibility
* Refactor get_updated_files with filter_map
* Refactor update
* Cleanup update_config --> upsert_config
* Fix updater specs
2020-05-01 11:23:48 -04:00
rhymes
2d26318cf9
[deploy] Replace (black|white)list with more inclusive language ( #7459 )
...
* Replace isBlacklisted
* Update fastly.rake task
* More renames
* Rename Faslty config file
* More changes
* Replace isForbiddenFromPreloading with isNotPreloadable
* Skip problematic test
* Re-enable
2020-04-27 18:00:12 +02:00
Alex
8b51d8e4b8
[deploy] Fix Fastly rake task spec and Travis CI ( #7487 )
...
* Try changing exit to next
* Add breaking test
* Fix search.rake
* Remove test failure
2020-04-23 16:06:57 -04:00
Alex
cc408d50e0
Fix Travis CI ( #7486 )
2020-04-23 13:23:34 -05:00
Alex
397734b29c
Generalize Fastly rake task ( #7349 )
...
* Generalize Fastly rake task
- Update Rubocop to disable DescribeClass on rake task specs
* Change default Fastly ENV vars to ""
* Move snippet name to ENV
* Update ENV to FASTLY_WHITELIST_PARAMS_SNIPPET_NAME
* Add FASTLY_WHITELIST_PARAMS_SNIPPET_NAME to the docs
* Update docs
* Quick refactor
2020-04-22 11:49:54 -04:00
Mac Siri
b5fa02bf33
Create Broadcasts.rake ( #7010 )
2020-04-02 17:24:39 -04:00
