Ben Halpern
27d6fbb285
Send user agent in open graph fetch so we don't block our own requests ( #19462 )
...
* Send user agent in open graph fetch
* Update app/services/open_graph.rb
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* Change user agent and test
---------
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
2023-05-17 15:49:35 -04:00
Jeremy Friesen
0c6b6b9e62
Ensuring that embed fallback renders URL ( #17680 )
...
Prior to this commit, our fallback HREF was using only the URL's
domain (e.g. `guides.rubyonrails.org/routing.html`) instead of the
provided URL (e.g. `https://guides.rubyonrails.org/routing.html `). This
resulted in the link resolving to
`<url-of-article>/guides.rubyonrails.org/routing.html`)
With this commit, we're using the given URL for the HREF.
An interesting side note, the Ruby on Rails guides includes an
`og:title` but not an `og:url` so we hit the fallback condition. Could
we use the given URL if `og:url` does not exist?
Fixes forem/forem#17679
2022-05-17 07:43:17 -04:00
Dwight Scott
dfdae481e4
cache open graph response ( #17157 )
...
* Trigger Build
* Cache the HTML response for quicker previews
* remove unnecessary comments
2022-04-07 13:53:20 -04:00
Dwight Scott
71294dca14
OpenGraph fallback for Embeds (merge-by-any-core) ( #17001 )
...
* WIP -- start of OpenGraph class that wraps MetaInspector gem
* use properties method instead of hash
* Update app/services/open_graph.rb
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* Update app/services/open_graph.rb
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* Update app/services/open_graph.rb
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* Update app/services/open_graph.rb
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* Update app/services/open_graph.rb
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* Update app/services/open_graph.rb
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* address PR feedback
* adding some specs
* gem vendor cache
* more specs
* lock metainspector gem to 5.11
* Update app/services/open_graph.rb
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* WIP -- start of incorporating the open graph into the view
* regex match anything
* Update app/liquid_tags/open_graph_tag.rb
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* Refactors and Improvements
* build UI (some wonkiness; see loom)
* UI improvements
* add hyperlink to embed url
* display site_name conditionally
* Make PR review changes; implement A-tag fallback for OG
* Address PR review comments
* Fix failing spec
* deleted superfluous assignment; switched filename annotations off
* nudge Travis
* Address PR feedback
* attempting to apply custom styles
* update specs
* update specs
* add favicon if exists
* remove site-name method
* styling changes ✨
* nudge Travis
* PR review comments
* keep border around A-tag fallback
* use preferred description
* remove www prefix from url
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Arit Amana <msarit@gmail.com>
2022-04-04 15:31:38 -04:00
