diff --git a/spec/models/comment_spec.rb b/spec/models/comment_spec.rb index b44f3e54e..c4c501598 100644 --- a/spec/models/comment_spec.rb +++ b/spec/models/comment_spec.rb @@ -1,9 +1,9 @@ require "rails_helper" RSpec.describe Comment, type: :model do - let_it_be(:user) { create(:user) } - let_it_be(:article) { create(:article, user: user) } - let_it_be_changeable(:comment) { create(:comment, user: user, commentable: article) } + let(:user) { create(:user) } + let(:article) { create(:article, user: user) } + let(:comment) { create(:comment, user: user, commentable: article) } include_examples "#sync_reactions_count", :article_comment @@ -255,8 +255,8 @@ RSpec.describe Comment, type: :model do end describe ".tree_for" do - let_it_be(:other_comment) { create(:comment, commentable: article, user: user) } - let_it_be(:child_comment) { create(:comment, commentable: article, parent: comment, user: user) } + let!(:other_comment) { create(:comment, commentable: article, user: user) } + let!(:child_comment) { create(:comment, commentable: article, parent: comment, user: user) } before { comment.update_column(:score, 1) } @@ -326,6 +326,8 @@ RSpec.describe Comment, type: :model do let!(:user) { create(:user) } before do + article + comment # making sure there are no other enqueued jobs from other tests sidekiq_perform_enqueued_jobs(only: Slack::Messengers::Worker) end diff --git a/spec/requests/api/v0/webhooks_spec.rb b/spec/requests/api/v0/webhooks_spec.rb index 8cd45fc28..fa0b74ad6 100644 --- a/spec/requests/api/v0/webhooks_spec.rb +++ b/spec/requests/api/v0/webhooks_spec.rb @@ -1,13 +1,13 @@ require "rails_helper" RSpec.describe "Api::V0::Webhooks", type: :request do - let_it_be_changeable(:user) { create(:user) } - let_it_be_changeable(:webhook) do + let(:user) { create(:user) } + let!(:webhook) do create(:webhook_endpoint, user: user, target_url: "https://api.example.com/go") end describe "GET /api/v0/webhooks" do - let_it_be_readonly(:webhook2) do + let(:webhook2) do create(:webhook_endpoint, user: user, target_url: "https://api.example.com/webhook") end @@ -55,6 +55,7 @@ RSpec.describe "Api::V0::Webhooks", type: :request do end it "returns json on success" do + webhook2 get api_webhooks_path expect(response.parsed_body).to include( diff --git a/vendor/cache/libv8-8.4.255.0-x86_64-darwin-18.gem b/vendor/cache/libv8-8.4.255.0-x86_64-darwin-18.gem new file mode 100644 index 000000000..1e2fb85c0 Binary files /dev/null and b/vendor/cache/libv8-8.4.255.0-x86_64-darwin-18.gem differ