From f4315489b2f32c21615da01b853814aa0d06b640 Mon Sep 17 00:00:00 2001 From: Molly Struve Date: Wed, 30 Dec 2020 15:34:00 -0500 Subject: [PATCH] Refactor:Use dev_to? to Check for DEV (#12083) --- app/services/email_digest.rb | 2 +- app/workers/articles/rss_reader_worker.rb | 2 +- app/workers/emails/enqueue_digest_worker.rb | 2 +- spec/services/email_digest_spec.rb | 2 +- spec/workers/articles/rss_reader_worker_spec.rb | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-) diff --git a/app/services/email_digest.rb b/app/services/email_digest.rb index 7988f9bd1..f0012c484 100644 --- a/app/services/email_digest.rb +++ b/app/services/email_digest.rb @@ -13,7 +13,7 @@ class EmailDigest # Temporary # @sre:mstruve This is temporary until we have an efficient way to handle this job # for our large DEV community. Smaller Forems should be able to handle it no problem - if SiteConfig.community_name == "DEV Community" + if SiteConfig.dev_to? Emails::SendUserDigestWorker.new.perform(user.id) else Emails::SendUserDigestWorker.perform_async(user.id) diff --git a/app/workers/articles/rss_reader_worker.rb b/app/workers/articles/rss_reader_worker.rb index 27874854a..cacb21ba2 100644 --- a/app/workers/articles/rss_reader_worker.rb +++ b/app/workers/articles/rss_reader_worker.rb @@ -8,7 +8,7 @@ module Articles # Temporary # @sre:mstruve This is temporary until we have an efficient way to handle this job # for our large DEV community. Smaller Forems should be able to handle it no problem - return if SiteConfig.community_name == "DEV Community" + return if SiteConfig.dev_to? if FeatureFlag.enabled?(:feeds_import) ::Feeds::ImportArticlesWorker.perform_async diff --git a/app/workers/emails/enqueue_digest_worker.rb b/app/workers/emails/enqueue_digest_worker.rb index 7e12eb20e..77fdec0cc 100644 --- a/app/workers/emails/enqueue_digest_worker.rb +++ b/app/workers/emails/enqueue_digest_worker.rb @@ -8,7 +8,7 @@ module Emails # Temporary # @sre:mstruve This is temporary until we have an efficient way to handle this job # for our large DEV community. Smaller Forems should be able to handle it no problem - return if SiteConfig.community_name == "DEV Community" + return if SiteConfig.dev_to? EmailDigest.send_periodic_digest_email end diff --git a/spec/services/email_digest_spec.rb b/spec/services/email_digest_spec.rb index 276c745d6..a8102d078 100644 --- a/spec/services/email_digest_spec.rb +++ b/spec/services/email_digest_spec.rb @@ -10,7 +10,7 @@ RSpec.describe EmailDigest, type: :service do end it "performs job inline if community is DEV" do - allow(SiteConfig).to receive(:community_name).and_return("DEV Community") + allow(SiteConfig).to receive(:dev_to?).and_return(true) user = create(:user, email_digest_periodic: true) worker = Emails::SendUserDigestWorker.new allow(worker).to receive(:perform) diff --git a/spec/workers/articles/rss_reader_worker_spec.rb b/spec/workers/articles/rss_reader_worker_spec.rb index 2eed441a0..76d0f711e 100644 --- a/spec/workers/articles/rss_reader_worker_spec.rb +++ b/spec/workers/articles/rss_reader_worker_spec.rb @@ -36,7 +36,7 @@ RSpec.describe Articles::RssReaderWorker, type: :worker do end it "short circuits if it's running on DEV" do - allow(SiteConfig).to receive(:community_name).and_return("DEV Community") + allow(SiteConfig).to receive(:dev_to?).and_return(true) allow(RssReader).to receive(:get_all_articles) allow(FeatureFlag).to receive(:enabled?)