Misc rubocop fixes (#7044)

* Fix violations

* rubocop autogen config

.rubocop_todo.yml

@@ -7,13 +7,13 @@ require:
 
 # This configuration was generated by
 # `rubocop --auto-gen-config`
-# on 2020-03-27 09:48:49 +0100 using RuboCop version 0.79.0.
+# on 2020-04-02 16:59:26 +0200 using RuboCop version 0.79.0.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
 # versions of RuboCop, may require this file to be generated again.
 
-# Offense count: 247
+# Offense count: 252
 Metrics/AbcSize:
   Max: 75
 
@@ -30,7 +30,7 @@ RSpec/ExampleLength:
     - 'spec/models/comment_spec.rb'
     - 'spec/requests/display_ad_events_spec.rb'
 
-# Offense count: 717
+# Offense count: 739
 # Configuration parameters: AggregateFailuresByDefault.
 RSpec/MultipleExpectations:
   Max: 8
@@ -40,7 +40,7 @@ RSpec/SubjectStub:
   Exclude:
     - 'spec/models/article_spec.rb'
 
-# Offense count: 2
+# Offense count: 3
 # Configuration parameters: Include.
 # Include: app/helpers/**/*.rb
 Rails/HelperInstanceVariable:
@@ -64,14 +64,14 @@ Rails/OutputSafety:
 Rails/UniqueValidationWithoutIndex:
   Enabled: false
 
-# Offense count: 32
+# Offense count: 33
 # Cop supports --auto-correct.
 # Configuration parameters: AutoCorrect, EnforcedStyle.
 # SupportedStyles: nested, compact
 Style/ClassAndModuleChildren:
   Enabled: false
 
-# Offense count: 4410
+# Offense count: 4586
 # Cop supports --auto-correct.
 # Configuration parameters: AutoCorrect, AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns.
 # URISchemes: http, https

db/seeds.rb

@@ -333,7 +333,6 @@ users_in_random_order.limit(10).each do |user|
   )
 end
 
-
 ##############################################################################
 
 counter += 1

spec/requests/internal/chat_channel_spec.rb

@@ -14,7 +14,7 @@ RSpec.describe "/internal/chat_channels", type: :request do
       sign_in user
       expect do
         post "/internal/chat_channels",
-             params: { chat_channel: { channel_name: "Hello Channel", usernames_string: "#{user.username}" } },
+             params: { chat_channel: { channel_name: "Hello Channel", usernames_string: user.username.to_s } },
              headers: { HTTP_ACCEPT: "application/json" }
       end.to change(ActionMailer::Base.deliveries, :length)
       expect(ChatChannel.last.channel_name).to eq("Hello Channel")