From ebefca6a8a775ad179f25bed7749800418c6f072 Mon Sep 17 00:00:00 2001 From: "dependabot-preview[bot]" <27856297+dependabot-preview[bot]@users.noreply.github.com> Date: Tue, 30 Jul 2019 16:47:08 -0400 Subject: [PATCH] Bump capybara from 3.26.0 to 3.27.0 (#3556) --- .travis.yml | 1 - Gemfile | 2 +- Gemfile.lock | 6 +++--- spec/support/initializers/capybara.rb | 9 ++++++++- spec/system/podcasts/user_visits_podcast_episode_spec.rb | 2 +- spec/system/user_visits_a_comments_page_spec.rb | 2 +- 6 files changed, 14 insertions(+), 8 deletions(-) diff --git a/.travis.yml b/.travis.yml index cc446b1e3..7194a3abf 100644 --- a/.travis.yml +++ b/.travis.yml @@ -9,7 +9,6 @@ rvm: - 2.6.3 addons: postgresql: '9.6' - chrome: stable env: global: - RAILS_ENV=test diff --git a/Gemfile b/Gemfile index 3bc01751a..bc0a5f3ba 100644 --- a/Gemfile +++ b/Gemfile @@ -119,7 +119,7 @@ end group :development, :test do gem "awesome_print", "~> 1.8" # Great Ruby dubugging companion: pretty print Ruby objects to visualize their structure gem "bullet", "~> 6.0" # help to kill N+1 queries and unused eager loading - gem "capybara", "~> 3.26" # Capybara is an integration testing tool for rack based web applications + gem "capybara", "~> 3.27" # Capybara is an integration testing tool for rack based web applications gem "faker", "~> 1.9" # A library for generating fake data such as names, addresses, and phone numbers gem "parallel_tests", "~> 2.29" # Run Test::Unit / RSpec / Cucumber / Spinach in parallel gem "pry-byebug", "~> 3.7" # Combine 'pry' with 'byebug'. Adds 'step', 'next', 'finish', 'continue' and 'break' commands to control execution diff --git a/Gemfile.lock b/Gemfile.lock index 04f2743fe..fd0a54772 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -170,7 +170,7 @@ GEM bundler (>= 1.2.0, < 3) thor (~> 0.18) byebug (11.0.0) - capybara (3.26.0) + capybara (3.27.0) addressable mini_mime (>= 0.1.3) nokogiri (~> 1.8) @@ -797,7 +797,7 @@ GEM activemodel (>= 5.0) bindex (>= 0.4.0) railties (>= 5.0) - webdrivers (4.1.1) + webdrivers (4.1.2) nokogiri (~> 1.6) rubyzip (~> 1.0) selenium-webdriver (>= 3.0, < 4.0) @@ -852,7 +852,7 @@ DEPENDENCIES buffer (~> 0.1) bullet (~> 6.0) bundler-audit (~> 0.6) - capybara (~> 3.26) + capybara (~> 3.27) carrierwave (~> 1.3) carrierwave-bombshelter (~> 0.2) cld (~> 0.8) diff --git a/spec/support/initializers/capybara.rb b/spec/support/initializers/capybara.rb index cdb5f555d..ceae0fb31 100644 --- a/spec/support/initializers/capybara.rb +++ b/spec/support/initializers/capybara.rb @@ -2,7 +2,7 @@ require "capybara/rails" require "capybara/rspec" require "webdrivers/chromedriver" -Webdrivers::Chromedriver.required_version = "74.0.3729.6" +Webdrivers::Chromedriver.required_version = "73.0.3683.68" Webdrivers.cache_time = 86_400 Capybara.default_max_wait_time = 5 @@ -14,6 +14,13 @@ Capybara.register_driver :headless_chrome do |app| Capybara::Selenium::Driver.new(app, browser: :chrome, desired_capabilities: capabilities) end +Capybara.register_driver :chrome do |app| + capabilities = Selenium::WebDriver::Remote::Capabilities.chrome( + chromeOptions: { args: %w[no-sandbox window-size=1400,2000] }, + ) + Capybara::Selenium::Driver.new(app, browser: :chrome, desired_capabilities: capabilities) +end + RSpec.configure do |config| config.before(:all, type: :system) do Capybara.server = :puma, { Silent: true } diff --git a/spec/system/podcasts/user_visits_podcast_episode_spec.rb b/spec/system/podcasts/user_visits_podcast_episode_spec.rb index f59743570..8576aa3b6 100644 --- a/spec/system/podcasts/user_visits_podcast_episode_spec.rb +++ b/spec/system/podcasts/user_visits_podcast_episode_spec.rb @@ -43,7 +43,7 @@ RSpec.describe "User visits podcast show page", type: :system do let(:comment) { create(:comment, user_id: user.id, commentable: podcast_episode) } let!(:comment2) { create(:comment, user_id: user.id, commentable: podcast_episode, parent: comment) } - it "sees the comments" do + it "sees the comments", js: true do visit podcast_episode.path.to_s expect(page).to have_selector(".comment-deep-0#comment-node-#{comment.id}", visible: true, count: 1) expect(page).to have_selector(".comment-deep-1#comment-node-#{comment2.id}", visible: true, count: 1) diff --git a/spec/system/user_visits_a_comments_page_spec.rb b/spec/system/user_visits_a_comments_page_spec.rb index ad167bb98..68bfa6584 100644 --- a/spec/system/user_visits_a_comments_page_spec.rb +++ b/spec/system/user_visits_a_comments_page_spec.rb @@ -1,6 +1,6 @@ require "rails_helper" -RSpec.describe "Views an article", type: :system do +RSpec.describe "Views an article", type: :system, js: true do let(:user) { create(:user) } let(:article) { create(:article, user: user) }