From e94f2f4e31bafbfb46ea79f39a322643ab0f67e3 Mon Sep 17 00:00:00 2001 From: Vaidehi Joshi Date: Wed, 10 Feb 2021 11:56:56 -0800 Subject: [PATCH] Update PR template with communicating changes section (#12603) * Update PR template with communicating changes section * Combine communicating changes with updating docs section * Add forem core team only tag to communicating changes * Specify team over teams --- .github/PULL_REQUEST_TEMPLATE.md | 22 ++++++++++++++++------ 1 file changed, 16 insertions(+), 6 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 851620795..d0b0dbfa3 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -49,13 +49,23 @@ accessibility is impacted and tested. For more info, check out the have not been included_ - [ ] I need help with writing tests -## Added to documentation? +## [Forem core team only] How will this change be communicated? -- [ ] [Developer Docs](https://docs.forem.com) and/or - [Admin Guide](https://forem.gitbook.io/forem-admin-guide/) -- [ ] [Storybook](https://storybook.forem.com/) (for Crayons components) -- [ ] README -- [ ] No documentation needed +_Will this PR introduce a change that impacts Forem members or creators, the +development process, or any of our internal teams? If so, please note how you +will share this change with the people who need to know about it._ + +- [ ] I've updated the [Developer Docs](https://docs.forem.com) and/or + [Admin Guide](https://forem.gitbook.io/forem-admin-guide/), or + [Storybook](https://storybook.forem.com/) (for Crayons components) +- [ ] I've updated the README or added inline documentation +- [ ] I will share this change in a [Changelog](https://forem.dev/t/changelog) + or in a [forem.dev](http://forem.dev) post +- [ ] I will share this change internally with the appropriate teams +- [ ] I'm not sure how best to communicate this change and need help +- [ ] This change does not need to be communicated, and this is why not: _please + replace this line with details on why this change doesn't need to be + shared_ ## [optional] Are there any post deployment tasks we need to perform?