From e3b6e5b08db1b8401d3591b43f1518eeaa54d523 Mon Sep 17 00:00:00 2001
From: Mac Siri <mac@forem.com>
Date: Mon, 3 Apr 2023 15:56:20 -0400
Subject: [PATCH] [CI] Make CodeCov less noisy (#19286)

---
 .github/workflows/ci-cd.yml |  2 ++
 codecov.yml                 | 18 ++++++++++++------
 2 files changed, 14 insertions(+), 6 deletions(-)

diff --git a/.github/workflows/ci-cd.yml b/.github/workflows/ci-cd.yml
index d3f737b85..87fdb3106 100644
--- a/.github/workflows/ci-cd.yml
+++ b/.github/workflows/ci-cd.yml
@@ -193,6 +193,7 @@ jobs:
       - uses: codecov/codecov-action@v3
         with:
           flags: ruby
+          fail_ci_if_error: false
       - name: Upload test results to BuildPulse for flaky test detection
         if: '!cancelled()' # Run this step even when the tests fail. Skip if the workflow is cancelled.
         uses: Workshop64/buildpulse-action@master
@@ -233,6 +234,7 @@ jobs:
       - uses: codecov/codecov-action@v3
         with:
           flags: jest, javascript
+          fail_ci_if_error: false
 
   storybook:
     runs-on: ubuntu-latest
diff --git a/codecov.yml b/codecov.yml
index ff9867826..ced61f919 100644
--- a/codecov.yml
+++ b/codecov.yml
@@ -1,6 +1,13 @@
+# NB: Run the following command to verify this file is valid
+# > cat codecov.yml | curl --data-binary @- https://codecov.io/validate
+
 codecov:
   ci:
-    - !buildkite
+    - "!buildkite"
+  require_ci_to_pass: no
+  notify:
+    wait_for_ci: no
+    after_n_builds: 12 # Actually we have 18 total but this ensure we get a (incomplete) result even if some failed to upload
 ignore:
   - "vendor"
   - "bin"
@@ -9,11 +16,10 @@ ignore:
   - "lib/generators"
 coverage:
   status:
-    patch: 90%
+    patch:
+      default:
+        target: 90%
+    project: false
 flag_management:
   default_rules:
     carryforward: true
-    statuses:
-      - type: project
-        target: auto
-        threshold: 1%