From e0d432908976921e9ca7f2d250b574c4daa087b2 Mon Sep 17 00:00:00 2001 From: Mario See Date: Thu, 9 May 2019 16:17:03 -0400 Subject: [PATCH] Utilize ERB template in SoundcloudTag (#2752) [ci skip] --- app/liquid_tags/soundcloud_tag.rb | 22 ++++++++----------- app/views/liquids/_soundcloud.html.erb | 8 +++++++ .../soundcloud_liquid_tag.approved.html | 3 ++- 3 files changed, 19 insertions(+), 14 deletions(-) create mode 100644 app/views/liquids/_soundcloud.html.erb diff --git a/app/liquid_tags/soundcloud_tag.rb b/app/liquid_tags/soundcloud_tag.rb index ce9768d9f..391ed6cc9 100644 --- a/app/liquid_tags/soundcloud_tag.rb +++ b/app/liquid_tags/soundcloud_tag.rb @@ -1,23 +1,19 @@ class SoundcloudTag < LiquidTagBase + PARTIAL = "liquids/soundcloud".freeze + def initialize(tag_name, link, tokens) super @link = parse_link(link) - @height = 166 end def render(_context) - # src = build_src - html = <<-HTML - - HTML - finalize_html(html) + ActionController::Base.new.render_to_string( + partial: PARTIAL, + locals: { + link: @link, + height: 166 + }, + ) end private diff --git a/app/views/liquids/_soundcloud.html.erb b/app/views/liquids/_soundcloud.html.erb new file mode 100644 index 000000000..f0ce2b7aa --- /dev/null +++ b/app/views/liquids/_soundcloud.html.erb @@ -0,0 +1,8 @@ + diff --git a/spec/support/fixtures/approvals/soundcloud_liquid_tag.approved.html b/spec/support/fixtures/approvals/soundcloud_liquid_tag.approved.html index 055e9d739..d32c76827 100644 --- a/spec/support/fixtures/approvals/soundcloud_liquid_tag.approved.html +++ b/spec/support/fixtures/approvals/soundcloud_liquid_tag.approved.html @@ -1,6 +1,7 @@ - +