From de3ee9ebecc900ee0d4701cee8958269692aba26 Mon Sep 17 00:00:00 2001 From: Alex Date: Tue, 4 Feb 2020 10:24:39 -0800 Subject: [PATCH] Move HtmlVariantSuccessesCreate from job to inline (#5879) [deploy] --- app/controllers/html_variant_successes_controller.rb | 2 +- app/jobs/html_variant_success_create_job.rb | 7 ------- spec/jobs/html_variant_success_create_job_spec.rb | 6 ------ 3 files changed, 1 insertion(+), 14 deletions(-) delete mode 100644 app/jobs/html_variant_success_create_job.rb delete mode 100644 spec/jobs/html_variant_success_create_job_spec.rb diff --git a/app/controllers/html_variant_successes_controller.rb b/app/controllers/html_variant_successes_controller.rb index d8ee87a6d..88343cd96 100644 --- a/app/controllers/html_variant_successes_controller.rb +++ b/app/controllers/html_variant_successes_controller.rb @@ -2,7 +2,7 @@ class HtmlVariantSuccessesController < ApplicationMetalController include ActionController::Head def create - HtmlVariantSuccessCreateJob.perform_later(html_variant_id: params[:html_variant_id], article_id: params[:article_id]) + HtmlVariantSuccess.create(html_variant_id: params[:html_variant_id], article_id: params[:article_id]) head :ok end end diff --git a/app/jobs/html_variant_success_create_job.rb b/app/jobs/html_variant_success_create_job.rb deleted file mode 100644 index d0b793817..000000000 --- a/app/jobs/html_variant_success_create_job.rb +++ /dev/null @@ -1,7 +0,0 @@ -class HtmlVariantSuccessCreateJob < ApplicationJob - queue_as :html_variant_success_create - - def perform(html_variant_id:, article_id:) - HtmlVariantSuccess.create(html_variant_id: html_variant_id, article_id: article_id) - end -end diff --git a/spec/jobs/html_variant_success_create_job_spec.rb b/spec/jobs/html_variant_success_create_job_spec.rb deleted file mode 100644 index 81893abb5..000000000 --- a/spec/jobs/html_variant_success_create_job_spec.rb +++ /dev/null @@ -1,6 +0,0 @@ -require "rails_helper" -require "jobs/shared_examples/enqueues_job" - -RSpec.describe HtmlVariantSuccessCreateJob, type: :job do - include_examples "#enqueues_job", "html_variant_success_create", [{ html_variant_id: 789, article_id: 456 }] -end