maverick/docbrown
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Optimize Admin::FeedbackMessagesController by adding proper indexes (#12415)

Browse source 
DEV has 30+ million email messages, to display some of them to the admin, they
all are scanned to find those that belong to the requested feedback messages.
This results in SQL queries that can take up to 15 seconds.

By adding an index, we cut the SQL response time to milliseconds.
This commit is contained in:
rhymes 2021-01-25 17:02:06 +01:00 • committed by GitHub
parent 8b5b19bfa8
commit dd0ee3dd72
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 11 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
db/migrate/20210125085442_add_indexes_to_ahoy_messages_feedback_message_id_and_feedback_messages_status.rb Normal file
View file

@ -0,0 +1,8 @@
class AddIndexesToAhoyMessagesFeedbackMessageIdAndFeedbackMessagesStatus < ActiveRecord::Migration[6.0]
disable_ddl_transaction!
def change
add_index :ahoy_messages, :feedback_message_id, algorithm: :concurrently
add_index :feedback_messages, :status, algorithm: :concurrently
end
end

4
db/schema.rb
View file

@ -10,7 +10,7 @@
#
# It's strongly recommended that you check this file into your version control system.
ActiveRecord::Schema.define(version: 2021_01_21_102114) do
ActiveRecord::Schema.define(version: 2021_01_25_085442) do
# These are extensions that must be enabled in order to support this database
enable_extension "citext"
@ -46,6 +46,7 @@ ActiveRecord::Schema.define(version: 2021_01_21_102114) do
t.string "utm_medium"
t.string "utm_source"
t.string "utm_term"
t.index ["feedback_message_id"], name: "index_ahoy_messages_on_feedback_message_id"
t.index ["to"], name: "index_ahoy_messages_on_to"
t.index ["token"], name: "index_ahoy_messages_on_token"
t.index ["user_id", "mailer"], name: "index_ahoy_messages_on_user_id_and_mailer"
@ -511,6 +512,7 @@ ActiveRecord::Schema.define(version: 2021_01_21_102114) do
t.index ["affected_id"], name: "index_feedback_messages_on_affected_id"
t.index ["offender_id"], name: "index_feedback_messages_on_offender_id"
t.index ["reporter_id"], name: "index_feedback_messages_on_reporter_id"
t.index ["status"], name: "index_feedback_messages_on_status"
end
create_table "field_test_events", force: :cascade do |t|