From db3cb9a42b2cf61d9d2e7053610970ef4bb8d2ab Mon Sep 17 00:00:00 2001 From: Julianna Tetreault <32834804+juliannatetreault@users.noreply.github.com> Date: Tue, 23 Jun 2020 13:05:48 -0600 Subject: [PATCH] Extract Welcome Broadcast Styling Into Its Own Stylesheet (#8862) [deploy] * Extract Welcome Broadcast styling into its own stylesheet - Adds a stylesheet, notifications-welcome-broadcast.scss, for broadcasts - Adds notifications-welcome-broadcast to minimal.scss - Removes .broadcast-content from notifications.scss - Adds TODOs for team-delightful to both stylesheets for future work * Adjust TODO to be more team-specific for future greps --- app/assets/stylesheets/minimal.scss | 1 + .../notifications-welcome-broadcast.scss | 20 +++++++++++++++++++ app/assets/stylesheets/notifications.scss | 9 ++------- 3 files changed, 23 insertions(+), 7 deletions(-) create mode 100644 app/assets/stylesheets/notifications-welcome-broadcast.scss diff --git a/app/assets/stylesheets/minimal.scss b/app/assets/stylesheets/minimal.scss index 3c1262132..ec320258a 100644 --- a/app/assets/stylesheets/minimal.scss +++ b/app/assets/stylesheets/minimal.scss @@ -17,6 +17,7 @@ @import 'comments'; @import 'leaderboard'; @import 'notifications'; +@import 'notifications-welcome-broadcast'; @import 'syntax'; @import 'signup-modal'; @import 'tags'; diff --git a/app/assets/stylesheets/notifications-welcome-broadcast.scss b/app/assets/stylesheets/notifications-welcome-broadcast.scss new file mode 100644 index 000000000..bb2102b4b --- /dev/null +++ b/app/assets/stylesheets/notifications-welcome-broadcast.scss @@ -0,0 +1,20 @@ +// TODO: [@thepracticaldev/delightful]: Refactor nesting in this file +// in addition to notifications.scss so that the nesting is +// not as deep as it currently is +.notifications-index { + .home { + .articles-list { + .single-article { + .content { + &.broadcast-content { + .opt-out { + padding-top: 24px; + font-size: 12px; + font-style: italic; + } + } + } + } + } + } +} diff --git a/app/assets/stylesheets/notifications.scss b/app/assets/stylesheets/notifications.scss index b65a49293..c067b4327 100644 --- a/app/assets/stylesheets/notifications.scss +++ b/app/assets/stylesheets/notifications.scss @@ -28,6 +28,8 @@ } } } + // TODO: [@thepracticaldev/delightful]: Remove .signup-cue-advanced and .sloan + // from stylesheet since it does not appear to be used anywhere .signup-cue-advanced { text-align: left; padding: 30px 25px; @@ -55,13 +57,6 @@ font-weight: 500; } } - &.broadcast-content { - .opt-out { - padding-top: 24px; - font-size: 12px; - font-style: italic; - } - } &.reaction-content { width: calc(100% - 145px); }