Removing uncalled method ✂✂✂ (#17110)
Introduced in forem/forem#3176, it appears that this method has been along for the ride. How did I find this? I saw an exception and realized that we cast our comment IDs from base-26 integer format to base-10. I decided to look through our code for `/\.to_\w\(26\)/` and stumbled upon the now removed instance. Quickly looking at the code, it appeared that this method was never called. So ✂✂✂
This commit is contained in:
parent
0963f72730
commit
d181041ae2
3 changed files with 0 additions and 10 deletions
|
|
@ -120,12 +120,6 @@ class PollTag < LiquidTagBase
|
|||
)
|
||||
end
|
||||
|
||||
def find_poll(id_code)
|
||||
Poll.find(id_code.to_i(26))
|
||||
rescue ActiveRecord::RecordNotFound
|
||||
raise StandardError, I18n.t("liquid_tags.poll_tag.invalid_poll_id")
|
||||
end
|
||||
|
||||
def self.script
|
||||
SCRIPT
|
||||
end
|
||||
|
|
|
|||
|
|
@ -64,8 +64,6 @@ en:
|
|||
invalid_parler_url: Invalid Parler URL
|
||||
podcast_tag:
|
||||
invalid_podcast_link: Invalid podcast link
|
||||
poll_tag:
|
||||
invalid_poll_id: Invalid poll ID
|
||||
reddit_tag:
|
||||
invalid_reddit_link: 'Invalid Reddit link: %{url}'
|
||||
replit_tag:
|
||||
|
|
|
|||
|
|
@ -64,8 +64,6 @@ fr:
|
|||
invalid_parler_url: Invalid Parler URL
|
||||
podcast_tag:
|
||||
invalid_podcast_link: Invalid podcast link
|
||||
poll_tag:
|
||||
invalid_poll_id: Invalid poll ID
|
||||
reddit_tag:
|
||||
invalid_reddit_link: 'Invalid Reddit link: %{url}'
|
||||
replit_tag:
|
||||
|
|
|
|||
Loading…
Add table
Reference in a new issue