From cfff766d3726b53fb3984d8bc848852686289bc0 Mon Sep 17 00:00:00 2001 From: rhymes Date: Fri, 21 May 2021 16:34:21 +0200 Subject: [PATCH] [Hotfix] Fix DataUpdateScripts::RemoveSiteConfigScripts script (#13824) --- ...0210518043957_remove_site_config_scripts.rb | 2 +- .../remove_site_config_scripts_spec.rb | 18 ++++++++++++++++++ 2 files changed, 19 insertions(+), 1 deletion(-) create mode 100644 spec/lib/data_update_scripts/remove_site_config_scripts_spec.rb diff --git a/lib/data_update_scripts/20210518043957_remove_site_config_scripts.rb b/lib/data_update_scripts/20210518043957_remove_site_config_scripts.rb index ec86dfe34..1164bdddf 100644 --- a/lib/data_update_scripts/20210518043957_remove_site_config_scripts.rb +++ b/lib/data_update_scripts/20210518043957_remove_site_config_scripts.rb @@ -11,7 +11,7 @@ module DataUpdateScripts ].freeze def run - DataUpdateScript.delete_by(name: SCRIPTS_TO_REMOVE) + DataUpdateScript.delete_by(file_name: SCRIPTS_TO_REMOVE) end end end diff --git a/spec/lib/data_update_scripts/remove_site_config_scripts_spec.rb b/spec/lib/data_update_scripts/remove_site_config_scripts_spec.rb new file mode 100644 index 000000000..df996da0b --- /dev/null +++ b/spec/lib/data_update_scripts/remove_site_config_scripts_spec.rb @@ -0,0 +1,18 @@ +require "rails_helper" +require Rails.root.join( + "lib/data_update_scripts/20210518043957_remove_site_config_scripts.rb", +) + +describe DataUpdateScripts::RemoveSiteConfigScripts do + it "removes scripts correctly from the DB", :aggregate_failures do + described_class::SCRIPTS_TO_REMOVE.each do |script_name| + create(:data_update_script, file_name: script_name) + end + + described_class.new.run + + described_class::SCRIPTS_TO_REMOVE.each do |script_name| + expect(DataUpdateScript.exists?(file_name: script_name)).to be(false) + end + end +end