From cfcc204a2053dec873a66d16c2ec25817cde6fb1 Mon Sep 17 00:00:00 2001
From: Arun Kumar <arunmohandm@gmail.com>
Date: Wed, 2 Jan 2019 10:42:42 -0500
Subject: [PATCH] Minor refactor (#1443)

* Rescue `ActiveRecord::RecordNotFound` exception instead of `StandardError`

* Replace `!blank?` call with `present?`
---
 app/services/user_role_service.rb | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/app/services/user_role_service.rb b/app/services/user_role_service.rb
index ef61148e8..a3b40fbbb 100644
--- a/app/services/user_role_service.rb
+++ b/app/services/user_role_service.rb
@@ -17,10 +17,10 @@ class UserRoleService
   def update_tag_moderators(user_ids, tag)
     users = user_ids.map do |id|
       User.find(id)
-    rescue StandardError
+    rescue ActiveRecord::RecordNotFound
       tag.errors[:moderator_ids] << ": user id #{id} was not found"
     end
-    return false if !tag.errors[:moderator_ids].blank?
+    return false if tag.errors[:moderator_ids].present?
     # Don't have to worry about comparing old and new values.
     tag.tag_moderator_ids.each do |id|
       User.find(id).remove_role(:tag_moderator, tag)