From cfbb5a1763c12910eda26ff7ebea7dc9080c8130 Mon Sep 17 00:00:00 2001
From: Julianna Tetreault <32834804+juliannatetreault@users.noreply.github.com>
Date: Wed, 21 Oct 2020 10:57:27 -0600
Subject: [PATCH] Standardize Image Placeholder Text in SiteConfig (#10992)
 [deploy]

* Standardizes image placeholder text in SiteConfig

* Adjusts image placeholder text URL per review suggestion

* Pulls image placeholder text out into a constant, IMAGE_PLACEHOLDER
---
 app/lib/constants/site_config.rb | 22 ++++++++++++----------
 1 file changed, 12 insertions(+), 10 deletions(-)

diff --git a/app/lib/constants/site_config.rb b/app/lib/constants/site_config.rb
index 9bb789dd0..03861e0c2 100644
--- a/app/lib/constants/site_config.rb
+++ b/app/lib/constants/site_config.rb
@@ -1,5 +1,7 @@
 module Constants
   module SiteConfig
+    IMAGE_PLACEHOLDER = "https://url/image.png".freeze
+
     DETAILS = {
       allow_email_password_registration: {
         description: "People can sign up using their email and password",
@@ -34,7 +36,7 @@ module Constants
         placeholder: "Campaign sidebar enabled or not"
       },
       campaign_sidebar_image: {
-        description: "https://image.url",
+        description: IMAGE_PLACEHOLDER,
         placeholder: "Used at the top of the campaign sidebar"
       },
       campaign_url: {
@@ -107,7 +109,7 @@ module Constants
       },
       favicon_url: {
         description: "Used as the site favicon",
-        placeholder: "https://image.url"
+        placeholder: IMAGE_PLACEHOLDER
       },
       feed_strategy: {
         description: "Determines the main feed algorithm approach the app takes: basic or large_forem_experimental
@@ -156,7 +158,7 @@ module Constants
       },
       logo_png: {
         description: "Minimum 1024px, used for PWA etc.",
-        placeholder: "https://image.url/image.png"
+        placeholder: IMAGE_PLACEHOLDER
       },
       logo_svg: {
         description: "Used as the SVG logo of the community",
@@ -164,7 +166,7 @@ module Constants
       },
       main_social_image: {
         description: "Used as the main image in social networks and OpenGraph",
-        placeholder: "https://image.url"
+        placeholder: IMAGE_PLACEHOLDER
       },
       mailchimp_api_key: {
         description: "API key used to connect Mailchimp account. Found in Mailchimp backend",
@@ -188,7 +190,7 @@ module Constants
       },
       mascot_footer_image_url: {
         description: "Special cute mascot image used in the footer.",
-        placeholder: "https://image.url"
+        placeholder: IMAGE_PLACEHOLDER
       },
       mascot_footer_image_width: {
         description: "The footer mascot width will resized to this value, defaults to 52",
@@ -204,7 +206,7 @@ module Constants
       },
       mascot_image_url: {
         description: "Used as the mascot image.",
-        placeholder: "https://image.url"
+        placeholder: IMAGE_PLACEHOLDER
       },
       mascot_user_id: {
         description: "User ID of the Mascot account",
@@ -216,15 +218,15 @@ module Constants
       },
       onboarding_background_image: {
         description: "Background for onboarding splash page",
-        placeholder: "https://image.url"
+        placeholder: IMAGE_PLACEHOLDER
       },
       onboarding_logo_image: {
         description: "Main onboarding display logo image",
-        placeholder: "https://image.url"
+        placeholder: IMAGE_PLACEHOLDER
       },
       onboarding_taskcard_image: {
         description: "Used as the onboarding task-card image",
-        placeholder: "https://image.url"
+        placeholder: IMAGE_PLACEHOLDER
       },
       payment_pointer: {
         description: "Used for site-wide web monetization. " \
@@ -253,7 +255,7 @@ module Constants
       },
       secondary_logo_url: {
         description: "Used as the secondary logo",
-        placeholder: "https://image.url"
+        placeholder: IMAGE_PLACEHOLDER
       },
       spam_trigger_terms: {
         description: "Individual (case insensitive) phrases that trigger spam alerts, comma separated.",