From ce965bcedf63f31dd1642879234fc35e893c71d1 Mon Sep 17 00:00:00 2001
From: Mac Siri <krairit.siri@gmail.com>
Date: Fri, 27 Jul 2018 12:04:52 -0400
Subject: [PATCH] Reduce Airbrake's error output (#628)

* Remove chmod for after_deploy

* Fix lint

* Ignore Pundit::NotAuthorizedError

* Update Travis config

* Turn off Travis' pr notification

* Add CommonsChunkPlugin to Webpacker
---
 .travis.yml                            |  6 ++++--
 app/javascript/packs/pack.js           |  2 +-
 app/views/layouts/application.html.erb |  4 ++++
 config/initializers/airbrake.rb        | 10 ++++++++--
 config/webpack/environment.js          | 22 +++++++++++++++++++++-
 5 files changed, 38 insertions(+), 6 deletions(-)

diff --git a/.travis.yml b/.travis.yml
index f5cda99ed..7bf8d3c53 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -44,8 +44,10 @@ deploy:
   run:
   - rake db:migrate
 after_deploy:
-- chmod -x after_deploy.sh
 - bash after_deploy.sh
 notifications:
   slack:
-    secure: R8v5+l8eblaTOB80ETP9YW+r10j+UoKVqqQubYwoA7GJSB3ElmQUjEggbL7w1a65F9hj7heJZLIlxejxV9i2mpuNsPO5DCSjxWoVTXQJuPhLKh5pAcM631rDewJzD/MdSkRKw7JcC5FMvHeRjeQ5DEElG2cZju17JEWahvUpxV9wGnUEADtH6o7X0xIb0fY0XGkg1SmnNGyPiZnWetrun9QGkQDNOTVCR9EUch+hAVAJfA8BhuvptwQxuhxPLJhJ8CkzRb4njXkuSWoczl9TPi0y1yv7E0Tg07f1GD/wJINOyFMSx5aw5j3zrJFtZQwg4dZDtOPwbdbxiqPkRtzEWbMjYBt2NnYkoq5Ke0h8A+m3jBm75fZZipN7qJlGfUdZgl8aGyAH10knfHu15Wob5DKrRXQYN46y0zKhFjKvDO83+Kth1LCMhOoEBvLjOZEdYgFo0nfQVi4Oy17OoSB2PbQCBs/tYi75Vv7GuFn+PZN0t0umMyQYWzjyDMbpQCxaJjnPxaUoVNKtXpnV2MgYKHl9Z3PLjnBJK8/D6nA76Sl9t1wDnj5zdStccGQraBlPOLyYpLuHeKCccRAGfemPEa1iHkbSXR9mEMSlmhZWmguE/R4APId1CcmIa470/C/tuL1jOz/w2G+IT9eLmjg967ftu3Vs5BEWbdYIWecGrcU=
+    on_pull_requests: false
+    on_success: always
+    rooms:
+      secure: CbEDtugX9cXV2j+ol9onsF9p//3Ym3fG299JHTb9sC2G2g3NgF3m9z6YZPjEVlqmTM/tG56H1K/m/zFHUkceezFUsz6iQSj7bqpNbvdJIhO5QRL3RnplNWiIdaa/t50meshTi3hx8JKo2R43YwsAY9T9jOQKTkpnOMYWq5UlleKlHeJi2HNmFNi9H1YJjByfF+RZIsaEft00ARqVwT1ebKY3g/AHoVgKuCAhKVYdAjx+5QZjwW9/cUfJG12i46RzGZ+D1Jt9mWOCTP/1TZcRRJyN0111Gh6OxADN3ZI0HFWmwPHWmEzyTShekHeM3T2aVfB+4Y0sY0MVy93MWEfWYSUzoKvjV5R50qWHTwMJuQ/NqnkO/IX1OtTgKNXrnbqcPtHZI20/oz+OBPnziRhnCletx+TRp241O5V3GpJW9koAXJL+TKzJXbKty91sHEDcykcKVE6G4b2zW13RArLIs4RZyrPimE6SXJF9tC9STLkFcvJ7z80mMUzp+trrHDKfT2MBTLdV3wHn0+rXW1rZHUPD3d0rHTWuzKbw+81MBxx0KL/O1Tv7pfbMZsa6jRae/04LRGEJB3iFuXfNET3gYdT3F6QkxgwmkdtyChdHQ9fEGl2LfsKKmkQGd+YSEJaUwfxAAkkJI/s0kGilTn3f1NiQl/fHSEpkW7cQsmMjEZc=
diff --git a/app/javascript/packs/pack.js b/app/javascript/packs/pack.js
index d00c20245..81f94d687 100644
--- a/app/javascript/packs/pack.js
+++ b/app/javascript/packs/pack.js
@@ -36,4 +36,4 @@ document.ready.then(
     renderPage();
     getUnopenedChannels();
   }),
-); 
+);
diff --git a/app/views/layouts/application.html.erb b/app/views/layouts/application.html.erb
index 9a59f13a1..84e403aff 100644
--- a/app/views/layouts/application.html.erb
+++ b/app/views/layouts/application.html.erb
@@ -33,6 +33,10 @@
         }
       }
     </style>
+
+    <%= javascript_pack_tag "manifest" %>
+    <%= javascript_pack_tag "vendor" %>
+
     <%= javascript_pack_tag 'Search', defer: true %>
     <% if core_pages? %>
       <%= javascript_include_tag 'base', defer: true %>
diff --git a/config/initializers/airbrake.rb b/config/initializers/airbrake.rb
index ee128f271..f17d9022c 100644
--- a/config/initializers/airbrake.rb
+++ b/config/initializers/airbrake.rb
@@ -12,8 +12,8 @@ Airbrake.configure do |c|
   # project_key navigate to your project's General Settings and copy the values
   # from the right sidebar.
   # https://github.com/airbrake/airbrake-ruby#project_id--project_key
-  c.project_id = ApplicationConfig['AIRBRAKE_PROJECT_ID']
-  c.project_key = ApplicationConfig['AIRBRAKE_API_KEY']
+  c.project_id = ApplicationConfig["AIRBRAKE_PROJECT_ID"]
+  c.project_key = ApplicationConfig["AIRBRAKE_API_KEY"]
 
   # Configures the root directory of your project. Expects a String or a
   # Pathname, which represents the path to your project. Providing this option
@@ -54,3 +54,9 @@ end
 # line below. It might simplify debugging of background Airbrake workers, which
 # can silently die.
 # Thread.abort_on_exception = ['test', 'development'].include?(Rails.env)
+
+Airbrake.add_filter do |notice|
+  if notice[:errors].any? { |error| error[:type] == "Pundit::NotAuthorizedError" }
+    notice.ignore!
+  end
+end
diff --git a/config/webpack/environment.js b/config/webpack/environment.js
index 89dc547d1..da47cd7cc 100644
--- a/config/webpack/environment.js
+++ b/config/webpack/environment.js
@@ -10,5 +10,25 @@
 
 
 const { environment } = require('@rails/webpacker')
+const webpack = require('webpack')
 
-module.exports = environment
\ No newline at end of file
+environment.plugins.append(
+  'CommonsChunkVendor',
+  new webpack.optimize.CommonsChunkPlugin({
+    name: 'vendor',
+    minChunks: (module) => {
+      // this assumes your vendor imports exist in the node_modules directory
+      return module.context && module.context.indexOf('node_modules') !== -1
+    }
+  })
+)
+
+environment.plugins.append(
+  'CommonsChunkManifest',
+  new webpack.optimize.CommonsChunkPlugin({
+    name: 'manifest',
+    minChunks: Infinity
+  })
+)
+
+module.exports = environment