maverick/docbrown
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix Mixed Content error in O RLY Parody Book Generator (#1993)

Browse source 
* Fixed image not loading + hide invalid gif

* Replaced other URLs with HTTPS
This commit is contained in:
Glenn Carremans 2019-03-07 16:10:58 +01:00 • committed by Ben Halpern
parent 5c116c4881
commit cb7ee46e35
1 changed files with 7 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
app/views/pages/generator.html.erb
View file

@ -11,7 +11,7 @@
<meta property="og:type" content="website" />
<meta property="og:url" content="https://dev.to/rlyslack" />
<meta property="og:title" content="O RLY Parody Book Generator for Slack" />
<meta property="og:image" content="http://i.imgur.com/OIT6xoq.png" />
<meta property="og:image" content="https://i.imgur.com/OIT6xoq.png" />
<meta property="og:description" content="Insult your co-workers with snarky O RLY parody book covers. All without leaving Slack!" />
<meta property="og:site_name" content="The Practical Dev" />
@ -19,14 +19,14 @@
<meta name="twitter:site" content="@ThePracticalDev">
<meta name="twitter:title" content="O RLY Parody Book Generator for Slack">
<meta name="twitter:description" content="Insult your co-workers with snarky O RLY parody book covers. All without leaving Slack!">
<meta name="twitter:image:src" content="http://i.imgur.com/OIT6xoq.png">
<meta name="twitter:image:src" content="https://i.imgur.com/OIT6xoq.png">
<% end %>
<div class="generator-container">
<h2><span class="typing"></span></h2>
<img class="loading" src="https://www.versioneye.com/assets/loadingbar-90e87b61b1413986fbe5fd642252b7b459407b4287394c76bd619ab05f8b0c69.gif" alt="loading" />
<img class="cover" src="http://i.imgur.com/XZ1UPCt.png" alt="Making Your Own Parody Covers" />
<img class="cover" src="https://i.imgur.com/XZ1UPCt.png" alt="Making Your Own Parody Covers" />
<a class="slack-butt" href="https://slack.com/oauth/authorize?scope=commands+bot+chat:write:bot+groups:write&client_id=3128000905.33373336070"><img alt="Add to Slack" height="40" width="139" src="https://platform.slack-edge.com/img/add_to_slack.png" srcset="https://platform.slack-edge.com/img/add_to_slack.png 1x, https://platform.slack-edge.com/img/add_to_slack@2x.png 2x"></a>
<h4>Insult your co-workers with snarky O RLY parody book covers. All without leaving Slack!</h4>
<a class="second-slack" href="https://slack.com/oauth/authorize?scope=commands+bot+chat:write:bot+groups:write&client_id=3128000905.33373336070"><img alt="Add to Slack" height="40" width="139" src="https://platform.slack-edge.com/img/add_to_slack.png" srcset="https://platform.slack-edge.com/img/add_to_slack.png 1x, https://platform.slack-edge.com/img/add_to_slack@2x.png 2x"></a>
@ -34,12 +34,12 @@
Loved by thousands of Slack teams!
<br />
<!-- Broken Deviant Art image -->
<img src="http://orig14.deviantart.net/587e/f/2016/074/a/5/heart_pulse_by_lalovelycake-d9v9nml.gif" />
<img src="http://orig14.deviantart.net/587e/f/2016/074/a/5/heart_pulse_by_lalovelycake-d9v9nml.gif" hidden />
</div>
<div class="thanks">
<h3>But don't thank
<a target="_blank" rel="noopener" href="http://twitter.com/ThePracticalDev">@ThePracticalDev</a> for this one</h3>
<h4>This tool was created with love by Charles Berlin (<a target="_blank" rel="noopener" href="http://twitter.com/AModelEngineer">@AModelEngineer</a>)
<a target="_blank" rel="noopener" href="https://twitter.com/ThePracticalDev">@ThePracticalDev</a> for this one</h3>
<h4>This tool was created with love by Charles Berlin (<a target="_blank" rel="noopener" href="https://twitter.com/AModelEngineer">@AModelEngineer</a>)
</h4>
</div>
<div class="usage">
@ -113,7 +113,7 @@
</div>
<div class="thanks feedback">
<h3>If you have any feedback, you can direct message
<a target="_blank" rel="noopener" href="http://twitter.com/ThePracticalDev">@ThePracticalDev</a> any time!</h3>
<a target="_blank" rel="noopener" href="https://twitter.com/ThePracticalDev">@ThePracticalDev</a> any time!</h3>
<a class="second-slack" href="https://slack.com/oauth/authorize?scope=commands+bot+chat:write:bot+groups:write&client_id=3128000905.33373336070"><img alt="Add to Slack" height="40" width="139" src="https://platform.slack-edge.com/img/add_to_slack.png" srcset="https://platform.slack-edge.com/img/add_to_slack.png 1x, https://platform.slack-edge.com/img/add_to_slack@2x.png 2x"></a>
</div>
</div>