From cae8ea2deb576f095f2c16f752b7465816f5fcf6 Mon Sep 17 00:00:00 2001
From: yheuhtozr <84892012+yheuhtozr@users.noreply.github.com>
Date: Tue, 25 Jan 2022 13:03:09 +0900
Subject: [PATCH] i18n key updates in app/liquid_tags (#16275)

---
 app/liquid_tags/tweet_tag.rb         | 2 +-
 app/liquid_tags/unified_embed/tag.rb | 2 +-
 config/locales/liquid_tags/en.yml    | 5 ++++-
 config/locales/liquid_tags/fr.yml    | 5 ++++-
 4 files changed, 10 insertions(+), 4 deletions(-)

diff --git a/app/liquid_tags/tweet_tag.rb b/app/liquid_tags/tweet_tag.rb
index 400e18e42..23e7698a6 100644
--- a/app/liquid_tags/tweet_tag.rb
+++ b/app/liquid_tags/tweet_tag.rb
@@ -53,7 +53,7 @@ class TweetTag < LiquidTagBase
 
   def parse_id_or_url(input)
     match = pattern_match_for(input, REGEXP_OPTIONS)
-    raise StandardError, "Invalid Tweet ID or URL" unless match
+    raise StandardError, I18n.t("liquid_tags.tweet_tag.invalid_twitter_id") unless match
 
     match[:id]
   end
diff --git a/app/liquid_tags/unified_embed/tag.rb b/app/liquid_tags/unified_embed/tag.rb
index 8f893714d..413dcdfe0 100644
--- a/app/liquid_tags/unified_embed/tag.rb
+++ b/app/liquid_tags/unified_embed/tag.rb
@@ -29,7 +29,7 @@ module UnifiedEmbed
       # notice that they didn't have a rich embed and instead published a basic
       # A-tag. In addition, said A-tag would goes nowhere; which may confuse
       # users and/or Forem readers.
-      raise StandardError, "Embed URL not valid" unless klass
+      raise StandardError, I18n.t("liquid_tags.unified_embed.tag.invalid_url") unless klass
 
       # Why the __send__?  Because a LiquidTagBase class "privatizes"
       # the `.new` method.  And we want to instantiate the specific
diff --git a/config/locales/liquid_tags/en.yml b/config/locales/liquid_tags/en.yml
index 37f79e4a6..11b032f80 100644
--- a/config/locales/liquid_tags/en.yml
+++ b/config/locales/liquid_tags/en.yml
@@ -90,11 +90,14 @@ en:
     tag_tag:
       invalid_tag_name: invalid tag name
     tweet_tag:
-      invalid_twitter_id: Invalid Twitter Id
+      invalid_twitter_id: Invalid Twitter ID or URL
     twitch_tag:
       invalid_twitch_id: Invalid Twitch ID, Slug or URL
     twitter_timeline_tag:
       invalid_url: Invalid Twitter Timeline URL
+    unified_embed:
+      tag:
+        invalid_url: Embed URL not valid
     user_subscription_tag:
       submit: Submit
       submitting: Submitting...
diff --git a/config/locales/liquid_tags/fr.yml b/config/locales/liquid_tags/fr.yml
index a1d0a7737..26d3adf3f 100644
--- a/config/locales/liquid_tags/fr.yml
+++ b/config/locales/liquid_tags/fr.yml
@@ -90,11 +90,14 @@ fr:
     tag_tag:
       invalid_tag_name: invalid tag name
     tweet_tag:
-      invalid_twitter_id: Invalid Twitter Id
+      invalid_twitter_id: Invalid Twitter ID or URL
     twitch_tag:
       invalid_twitch_id: Invalid Twitch ID, Slug or URL
     twitter_timeline_tag:
       invalid_url: Invalid Twitter Timeline URL
+    unified_embed:
+      tag:
+        invalid_url: Embed URL not valid
     user_subscription_tag:
       submit: Submit
       submitting: Submitting...