maverick/docbrown
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

[deploy] Fix TypeError: Cannot set property 'innerHTML' of null (#9306)

Browse source 
Should fix https://app.honeybadger.io/fault/67192/f79e24dfb4e4364da09dda6380e9d2ff.
This commit is contained in:
Vaidehi Joshi 2020-07-14 12:03:34 -07:00 • committed by GitHub
parent df273b62e1
commit ca06e4e357
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
app/views/articles/_search.html.erb
View file

@ -16,13 +16,13 @@
var params = getQueryParams(document.location.search);
function searchMain() {
function searchMain(substories) {
var query = filterXSS(params.q);
var filters = filterXSS(params.filters || "");
var sortBy = filterXSS(params.sort_by || "");
var sortDirection = filterXSS(params.sort_direction || "");
document.getElementById("substories").innerHTML = '<div class="query-results-nothing"><div class="query-results-loader"></div><br/></div>'
substories.innerHTML = '<div class="query-results-nothing"><div class="query-results-loader"></div><br/></div>';
if (document.getElementById("query-wrapper")) {
search(query, filters, sortBy, sortDirection);
initializeFilters(query, filters);
@ -189,8 +189,9 @@
var waitingOnSearch = setInterval(function () {
if (typeof search == 'function' && typeof filterXSS == 'function' && typeof buildArticleHTML == 'function') {
clearInterval(waitingOnSearch);
if (document.querySelectorAll('.search-results-loaded').length == 0) {
searchMain();
const substories = document.getElementById("substories");
if (document.querySelectorAll('.search-results-loaded').length == 0 && substories) {
searchMain(substories);
}
}
}, 1);