diff --git a/app/models/html_variant.rb b/app/models/html_variant.rb index 4d7bd4282..715085cb3 100644 --- a/app/models/html_variant.rb +++ b/app/models/html_variant.rb @@ -1,4 +1,6 @@ class HtmlVariant < ApplicationRecord + self.ignored_columns = %w[success_rate].freeze + resourcify GROUP_NAMES = %w[article_show_below_article_cta badge_landing_page campaign].freeze diff --git a/db/migrate/20221020120850_drop_html_variant_tracking_tables.rb b/db/migrate/20221020120850_drop_html_variant_tracking_tables.rb new file mode 100644 index 000000000..320880cee --- /dev/null +++ b/db/migrate/20221020120850_drop_html_variant_tracking_tables.rb @@ -0,0 +1,12 @@ +class DropHtmlVariantTrackingTables < ActiveRecord::Migration[7.0] + def up + safety_assured do + drop_table :html_variant_trials + drop_table :html_variant_successes + end + end + + def down + raise ActiveRecord::IrreversibleMigratione + end +end diff --git a/db/schema.rb b/db/schema.rb index 58e2cc91a..9c80404da 100644 --- a/db/schema.rb +++ b/db/schema.rb @@ -10,7 +10,7 @@ # # It's strongly recommended that you check this file into your version control system. -ActiveRecord::Schema[7.0].define(version: 2022_10_03_103855) do +ActiveRecord::Schema[7.0].define(version: 2022_10_20_120850) do # These are extensions that must be enabled in order to support this database enable_extension "citext" enable_extension "pg_stat_statements" @@ -580,22 +580,6 @@ ActiveRecord::Schema[7.0].define(version: 2022_10_03_103855) do t.index ["url"], name: "index_github_repos_on_url", unique: true end - create_table "html_variant_successes", force: :cascade do |t| - t.bigint "article_id" - t.datetime "created_at", precision: nil, null: false - t.bigint "html_variant_id" - t.datetime "updated_at", precision: nil, null: false - t.index ["html_variant_id", "article_id"], name: "index_html_variant_successes_on_html_variant_id_and_article_id" - end - - create_table "html_variant_trials", force: :cascade do |t| - t.bigint "article_id" - t.datetime "created_at", precision: nil, null: false - t.bigint "html_variant_id" - t.datetime "updated_at", precision: nil, null: false - t.index ["html_variant_id", "article_id"], name: "index_html_variant_trials_on_html_variant_id_and_article_id" - end - create_table "html_variants", force: :cascade do |t| t.boolean "approved", default: false t.datetime "created_at", precision: nil, null: false @@ -1381,10 +1365,6 @@ ActiveRecord::Schema[7.0].define(version: 2022_10_03_103855) do add_foreign_key "feedback_messages", "users", column: "offender_id", on_delete: :nullify add_foreign_key "feedback_messages", "users", column: "reporter_id", on_delete: :nullify add_foreign_key "github_repos", "users", on_delete: :cascade - add_foreign_key "html_variant_successes", "articles", on_delete: :nullify - add_foreign_key "html_variant_successes", "html_variants", on_delete: :cascade - add_foreign_key "html_variant_trials", "articles", on_delete: :nullify - add_foreign_key "html_variant_trials", "html_variants", on_delete: :cascade add_foreign_key "html_variants", "users", on_delete: :cascade add_foreign_key "identities", "users", on_delete: :cascade add_foreign_key "mentions", "users", on_delete: :cascade diff --git a/db/seeds.rb b/db/seeds.rb index 2023175c0..d982fa727 100644 --- a/db/seeds.rb +++ b/db/seeds.rb @@ -412,7 +412,6 @@ seeder.create_if_none(HtmlVariant) do name: rand(100).to_s, group: "badge_landing_page", html: rand(1000).to_s, - success_rate: 0, published: true, approved: true, user_id: User.first.id, diff --git a/spec/factories/html_variants.rb b/spec/factories/html_variants.rb index 5067cb40d..385912a4d 100644 --- a/spec/factories/html_variants.rb +++ b/spec/factories/html_variants.rb @@ -3,7 +3,6 @@ FactoryBot.define do user name { Faker::Hipster.paragraph(sentence_count: 1) } html { "