From c25cd81d15315b2eaba8d65e2145dda0f7c4de75 Mon Sep 17 00:00:00 2001 From: Zhao-Andy Date: Thu, 26 Apr 2018 16:52:00 -0400 Subject: [PATCH] Exclude self and already followed from suggestions --- app/labor/user_follow_suggester.rb | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/app/labor/user_follow_suggester.rb b/app/labor/user_follow_suggester.rb index 984705f95..fa4e01884 100644 --- a/app/labor/user_follow_suggester.rb +++ b/app/labor/user_follow_suggester.rb @@ -35,10 +35,10 @@ class UserFollowSuggester def sidebar_suggestions(given_tag) user_ids = Article.tagged_with([given_tag], any: true). - where("published = ? AND positive_reactions_count > ? AND published_at > ?", - true, 15, 7.months.ago). - pluck(:user_id) - User.where(id: user_ids).order("reputation_modifier DESC").limit(3).to_a + where("published = ? AND positive_reactions_count > ? AND published_at > ? AND user_id != ?", + true, 15, 7.months.ago, user.id).pluck(:user_id) + user.following_by_type("User").where.not(id: user_ids). + order("reputation_modifier DESC").limit(3).to_a end def tagged_article_user_ids