From c15120b902995c19bb7716a034802878434344e1 Mon Sep 17 00:00:00 2001 From: Jamie Gaskins Date: Mon, 8 Mar 2021 16:27:33 -0500 Subject: [PATCH] Fix ddtrace warnings at app start (#12941) * Load HTTPClient before Datadog The instrumentation needs it to be loaded before it can patch the request methods. * Don't split HTTPClient traces on domains yet After the service explosion in Datadog APM last time, let's take a more cautious approach. * Turns out, we aren't even using the aws-sdk gems This was added because we use Fog's AWS adapter, but Fog uses Excon (which we're already instrumenting) instead of the AWS SDK directly. --- app/lib/forem_stats_drivers/datadog_driver.rb | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/app/lib/forem_stats_drivers/datadog_driver.rb b/app/lib/forem_stats_drivers/datadog_driver.rb index e7ede4c87..097d50029 100644 --- a/app/lib/forem_stats_drivers/datadog_driver.rb +++ b/app/lib/forem_stats_drivers/datadog_driver.rb @@ -1,3 +1,5 @@ +require "httpclient" + module ForemStatsDrivers class DatadogDriver include ActsAsForemStatsDriver @@ -16,9 +18,8 @@ module ForemStatsDrivers c.use :http, split_by_domain: false c.use :faraday, split_by_domain: true c.use :excon, split_by_domain: true - c.use :httpclient, split_by_domain: true + c.use :httpclient, split_by_domain: false c.use :httprb, split_by_domain: true - c.use :aws c.use :rest_client c.use :concurrent_ruby end