maverick/docbrown
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Flaky Spec Fix:(Attempt)Ensure Article Suggester Count is Consistent (#10146)

Browse source
This commit is contained in:
Molly Struve 2020-09-01 19:27:46 -05:00 • committed by GitHub
parent 5657067e55
commit b60c6c687c
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 8 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
spec/labor/article_suggester_spec.rb
View file

@ -4,6 +4,7 @@ RSpec.describe ArticleSuggester, type: :labor do
it "returns proper number of articles with post with the same tags" do
create_list(:article, 4, featured: true, tags: ["discuss"], score: 10)
article = create(:article, featured: true, tags: ["discuss"])
stub_estimated_article_count
expect(described_class.new(article).articles.size).to eq(4)
end
@ -11,17 +12,24 @@ RSpec.describe ArticleSuggester, type: :labor do
create_list(:article, 2, featured: true, tags: ["discuss"], score: 10)
create_list(:article, 2, featured: true, tags: ["javascript"])
article = create(:article, featured: true, tags: ["discuss"])
stub_estimated_article_count
expect(described_class.new(article).articles.size).to eq(4)
end
it "returns proper number of articles with post without tags" do
create_list(:article, 5, tags: [], with_tags: false, featured: true)
article = create(:article, featured: true, tag_list: "")
stub_estimated_article_count
expect(described_class.new(article).articles.size).to eq(4)
end
it "returns the number of articles requested" do
articles = create_list(:article, 3, featured: true)
stub_estimated_article_count
expect(described_class.new(articles.first).articles(max: 2).size).to eq(2)
end
def stub_estimated_article_count
allow(described_class).to receive(:articles_count).and_return(Article.published.count)
end
end