From b5de27f1a63bd69f7ea68e79adcca7da284c2712 Mon Sep 17 00:00:00 2001 From: Brunno Souza Date: Fri, 10 Jul 2020 12:24:36 -0300 Subject: [PATCH] Refactoring comments_controller#create reducing lines (#9162) --- app/controllers/comments_controller.rb | 22 ++-------------------- app/views/comments/_comment.json.jbuilder | 18 ++++++++++++++++++ 2 files changed, 20 insertions(+), 20 deletions(-) create mode 100644 app/views/comments/_comment.json.jbuilder diff --git a/app/controllers/comments_controller.rb b/app/controllers/comments_controller.rb index 8b8d2d88c..c34146bec 100644 --- a/app/controllers/comments_controller.rb +++ b/app/controllers/comments_controller.rb @@ -77,26 +77,8 @@ class CommentsController < ApplicationController return end - render json: { - status: "created", - css: @comment.custom_css, - depth: @comment.depth, - url: @comment.path, - readable_publish_date: @comment.readable_publish_date, - published_timestamp: @comment.decorate.published_timestamp, - body_html: @comment.processed_html, - id: @comment.id, - id_code: @comment.id_code_generated, - newly_created: true, - user: { - id: current_user.id, - username: current_user.username, - name: current_user.name, - profile_pic: ProfileImage.new(current_user).get(width: 50), - twitter_username: current_user.twitter_username, - github_username: current_user.github_username - } - } + render partial: "comments/comment.json" + elsif (comment = Comment.where( body_markdown: @comment.body_markdown, commentable_id: @comment.commentable.id, diff --git a/app/views/comments/_comment.json.jbuilder b/app/views/comments/_comment.json.jbuilder new file mode 100644 index 000000000..be524362c --- /dev/null +++ b/app/views/comments/_comment.json.jbuilder @@ -0,0 +1,18 @@ +json.status "created" +json.css @comment.custom_css +json.depth @comment.depth +json.url @comment.path +json.readable_publish_date @comment.readable_publish_date +json.published_timestamp @comment.decorate.published_timestamp +json.body_html @comment.processed_html +json.id @comment.id +json.id_code @comment.id_code_generated +json.newly_created true +json.user do + json.id current_user.id + json.username current_user.username + json.name current_user.name + json.profile_pic ProfileImage.new(current_user).get(width: 50) + json.twitter_username current_user.twitter_username + json.github_username current_user.github_username +end