maverick/docbrown
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Revert "Refactor editor tags selector to fetch all tag info in one network call (#16841)" (#16900)

Browse source 
This reverts commit 7c1993604c.
This commit is contained in:
Suzanne Aitchison 2022-03-17 10:49:35 +00:00 • committed by GitHub
parent 7c1993604c
commit b498dd9867
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 13 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

25
app/javascript/article-form/components/TagsField.jsx
View file

@ -29,19 +29,20 @@ export const TagsField = ({ onInput, defaultValue, switchHelpContext }) => {
// Fetching further tag data allows us to display a richer UI
// This fetch only happens once on first component load
if (defaultValue && defaultValue !== '' && !defaultsLoaded) {
const tagNamesQueryString = defaultValue
.split(', ')
.reduce((queryString, nextTagName) => {
if (nextTagName) {
return queryString
? `${queryString}&tag_names[]=${nextTagName}`
: `tag_names[]=${nextTagName}`;
}
}, '');
const tagNames = defaultValue.split(', ');
fetch(`/tags/bulk?${tagNamesQueryString}`)
.then((res) => res.json())
.then((data) => setDefaultSelections(data));
const tagRequests = tagNames.map((tagName) =>
fetchSearch('tags', { name: tagName }).then(({ result = [] }) => {
const [potentialMatch = {}] = result;
return potentialMatch.name === tagName
? potentialMatch
: { name: tagName };
}),
);
Promise.all(tagRequests).then((data) => {
setDefaultSelections(data);
});
}
setDefaultsLoaded(true);
}, [defaultValue, defaultsLoaded]);