From b34387f384ff0c369e61e95b2c036e44cfe496e3 Mon Sep 17 00:00:00 2001
From: Arun Kumar <arunmohandm@gmail.com>
Date: Tue, 11 Jun 2019 09:28:25 -0500
Subject: [PATCH] Refactor Credit's array creation (#3116) [ci skip]

---
 app/controllers/api/v0/articles_controller.rb |  5 +----
 app/models/credit.rb                          | 10 ++--------
 2 files changed, 3 insertions(+), 12 deletions(-)

diff --git a/app/controllers/api/v0/articles_controller.rb b/app/controllers/api/v0/articles_controller.rb
index 1e3386955..b2b014b76 100644
--- a/app/controllers/api/v0/articles_controller.rb
+++ b/app/controllers/api/v0/articles_controller.rb
@@ -45,10 +45,7 @@ module Api
                    else
                      %w[career discuss productivity]
                    end
-        @articles = []
-        4.times do
-          @articles << Suggester::Articles::Classic.new.get(tag_list)
-        end
+        @articles = Array.new(4) { Suggester::Articles::Classic.new.get(tag_list) }
         Article.tagged_with(tag_list, any: true).
           order("published_at DESC").
           where("positive_reactions_count > ? OR comments_count > ? AND published = ?", 10, 3, true).
diff --git a/app/models/credit.rb b/app/models/credit.rb
index 7205cd474..5781834a9 100644
--- a/app/models/credit.rb
+++ b/app/models/credit.rb
@@ -20,10 +20,7 @@ class Credit < ApplicationRecord
                   }
 
   def self.add_to(user, amount)
-    credit_objects = []
-    amount.times do
-      credit_objects << Credit.new(user_id: user.id)
-    end
+    credit_objects = Array.new(amount) { Credit.new(user_id: user.id) }
     Credit.import credit_objects
   end
 
@@ -32,10 +29,7 @@ class Credit < ApplicationRecord
   end
 
   def self.add_to_org(org, amount)
-    credit_objects = []
-    amount.times do
-      credit_objects << Credit.new(organization_id: org.id)
-    end
+    credit_objects = Array.new(amount) { Credit.new(organization_id: org.id) }
     Credit.import credit_objects
   end