From b2b1068715b8101781f2b3854add5370d1075c61 Mon Sep 17 00:00:00 2001 From: Ben Halpern Date: Thu, 19 Jul 2018 15:36:29 -0400 Subject: [PATCH] Add minimum name length for users (#594) --- app/models/user.rb | 2 +- spec/models/user_spec.rb | 7 +++++++ 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/app/models/user.rb b/app/models/user.rb index d5800e7b0..183003195 100644 --- a/app/models/user.rb +++ b/app/models/user.rb @@ -40,7 +40,7 @@ class User < ApplicationRecord length: { maximum: 50 }, email: true, allow_blank: true - validates :name, length: { maximum: 100 } + validates :name, length: { minimum: 1, maximum: 100 } validates :username, presence: true, uniqueness: { case_sensitive: false }, diff --git a/spec/models/user_spec.rb b/spec/models/user_spec.rb index 55d6c7712..234acb541 100644 --- a/spec/models/user_spec.rb +++ b/spec/models/user_spec.rb @@ -145,6 +145,13 @@ RSpec.describe User, type: :model do expect(user.old_old_username).to eq(old_username) end + it "does not allow too short or too long name" do + user.name = "" + expect(user).not_to be_valid + user.name = Faker::Lorem.paragraph_by_chars(200) + expect(user).not_to be_valid + end + it "does not accept invalid employer url" do user.employer_url = "ben.com" expect(user).not_to be_valid