From b284c1e9df656627c72770f862c3711b36c3bdea Mon Sep 17 00:00:00 2001 From: Mazen Touati <14861869+mazentouati@users.noreply.github.com> Date: Wed, 19 Jun 2019 02:35:16 +0100 Subject: [PATCH] Allow stackoverflow subcommunities profiles (#3215) --- app/models/user.rb | 2 +- spec/models/user_spec.rb | 14 ++++++++++++++ 2 files changed, 15 insertions(+), 1 deletion(-) diff --git a/app/models/user.rb b/app/models/user.rb index cc2387ad0..de51a4c52 100644 --- a/app/models/user.rb +++ b/app/models/user.rb @@ -80,7 +80,7 @@ class User < ApplicationRecord validates :stackoverflow_url, allow_blank: true, format: - /\A(http(s)?:\/\/)?(www.stackoverflow.com|stackoverflow.com|www.stackexchange.com|stackexchange.com)\/.*\Z/ + /\A(http(s)?:\/\/)?(((www|pt|ru|es|ja).)?stackoverflow.com|(www.)?stackexchange.com)\/.*\Z/ validates :behance_url, allow_blank: true, format: /\A(http(s)?:\/\/)?(www.behance.net|behance.net)\/.*\Z/ diff --git a/spec/models/user_spec.rb b/spec/models/user_spec.rb index d539ff1ab..9f97f80db 100644 --- a/spec/models/user_spec.rb +++ b/spec/models/user_spec.rb @@ -194,6 +194,20 @@ RSpec.describe User, type: :model do expect(user).not_to be_valid end + it "accepts valid stackoverflow sub community url" do + %w[pt ru es ja].each do |subcommunity| + user.stackoverflow_url = "https://#{subcommunity}.stackoverflow.com/users/7381391/mazen" + expect(user).to be_valid + end + end + + + it "does not accept invalid stackoverflow sub community url" do + user.stackoverflow_url = "https://fr.stackoverflow.com/users/7381391/mazen" + expect(user).not_to be_valid + end + + it "accepts valid https linkedin url" do %w[jessleenyc jessleenyc/ jess-lee-nyc].each do |username| user.linkedin_url = "https://linkedin.com/in/#{username}"