maverick/docbrown
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix mod notifications for draft posts (#19575)

Browse source 
* Fix mod notifications for draft posts

* Rubocop
This commit is contained in:
Joshua Wehner 2023-06-05 17:02:11 +02:00 • committed by GitHub
parent 4ffe7b0fab
commit afa74111a8
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 18 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
app/models/article.rb
View file

@ -205,7 +205,7 @@ class Article < ApplicationRecord
after_save :bust_cache
after_save :collection_cleanup
after_create_commit :send_to_moderator
after_create_commit :send_to_moderator, if: :published?
after_update_commit :update_notifications, if: proc { |article|
article.notifications.any? && !article.saved_changes.empty?

21
spec/models/article_spec.rb
View file

@ -700,8 +700,8 @@ RSpec.describe Article do
describe "#slug" do
let(:title) { "hey This' is$ a SLUG" }
let(:article0) { build(:article, title: title, published: false) }
let(:article1) { build(:article, title: title, published: false) }
let(:article0) { build(:article, title: title, published: false) } # rubocop:disable RSpec/IndexedLet
let(:article1) { build(:article, title: title, published: false) } # rubocop:disable RSpec/IndexedLet
before do
article0.validate!
@ -1218,7 +1218,7 @@ RSpec.describe Article do
co_author1 = create(:user)
co_author2 = create(:user)
article.co_author_ids_list = "#{co_author1.id}, #{co_author2.id}"
expect(article.co_author_ids).to match_array([co_author1.id, co_author2.id])
expect(article.co_author_ids).to contain_exactly(co_author1.id, co_author2.id)
end
end
@ -1356,7 +1356,20 @@ RSpec.describe Article do
it "reports accurately" do
categories = article.public_reaction_categories
expect(categories.map(&:slug)).to contain_exactly(*%i[like])
expect(categories.map(&:slug)).to match_array(%i[like])
end
end
it "does not send moderator notifications when a draft post" do
allow(Notification).to receive(:send_moderation_notification)
draft_post = build(:article, published: false)
draft_post.save!
expect(draft_post).not_to be_published
expect(Notification).not_to have_received(:send_moderation_notification)
published_post = build(:article, published: true)
published_post.save!
expect(Notification).to have_received(:send_moderation_notification)
end
end