From ac8e5b4fb0883c362da3365b7b6d28cf5d54164d Mon Sep 17 00:00:00 2001 From: Molly Struve Date: Thu, 19 Dec 2019 10:53:50 -0600 Subject: [PATCH] Return not_found error if org is not found (#5179) [deploy] --- app/controllers/organizations_controller.rb | 1 + spec/requests/organizations_update_spec.rb | 7 +++++++ 2 files changed, 8 insertions(+) diff --git a/app/controllers/organizations_controller.rb b/app/controllers/organizations_controller.rb index 7173259da..79f8922f3 100644 --- a/app/controllers/organizations_controller.rb +++ b/app/controllers/organizations_controller.rb @@ -79,6 +79,7 @@ class OrganizationsController < ApplicationController def set_organization @organization = Organization.find_by(id: organization_params[:id]) + not_found unless @organization authorize @organization end end diff --git a/spec/requests/organizations_update_spec.rb b/spec/requests/organizations_update_spec.rb index 9c20e4b9f..a2b613a8a 100644 --- a/spec/requests/organizations_update_spec.rb +++ b/spec/requests/organizations_update_spec.rb @@ -30,4 +30,11 @@ RSpec.describe "OrganizationsUpdate", type: :request do put "/organizations/#{org_id}", params: { organization: { id: org_id, text_color_hex: "#111111" } } expect(Organization.last.profile_updated_at).to be > 2.minutes.ago end + + it "returns not_found if organization is missing" do + invalid_id = org_id + 100 + expect do + put "/organizations/#{invalid_id}", params: { organization: { id: invalid_id, text_color_hex: "#111111" } } + end.to raise_error(ActiveRecord::RecordNotFound) + end end