From 9cdd03f0dc39ff4b78697e2b141f0e17b2bfc344 Mon Sep 17 00:00:00 2001
From: rhymes <rhymesete@gmail.com>
Date: Wed, 24 Jun 2020 14:03:27 +0200
Subject: [PATCH] Fix typo in dashboard sort element (#8875)

---
 .../initializers/initializeDashboardSort.js          | 12 ++++++------
 app/views/dashboards/show.html.erb                   |  2 +-
 2 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/app/assets/javascripts/initializers/initializeDashboardSort.js b/app/assets/javascripts/initializers/initializeDashboardSort.js
index 05620a3ec..4c8d431be 100644
--- a/app/assets/javascripts/initializers/initializeDashboardSort.js
+++ b/app/assets/javascripts/initializers/initializeDashboardSort.js
@@ -1,11 +1,11 @@
 'use strict';
 
 function initializeDashboardSort() {
-  if (document.getElementById('dashhboard_sort')) {
-    document
-      .getElementById('dashhboard_sort')
-      .addEventListener('change', event => {
-        window.location = '/dashboard?sort=' + event.target.value;
-      });
+  const dashboardSorter = document.getElementById('dashboard_sort');
+
+  if (dashboardSorter) {
+    dashboardSorter.addEventListener('change', (event) => {
+      window.location.assign(`/dashboard?sort=${event.target.value}`);
+    });
   }
 }
diff --git a/app/views/dashboards/show.html.erb b/app/views/dashboards/show.html.erb
index d79aa0c6b..03aac519e 100644
--- a/app/views/dashboards/show.html.erb
+++ b/app/views/dashboards/show.html.erb
@@ -42,7 +42,7 @@
         <a class="video-upload-cta cta" href="/listings/dashboard" data-no-instant>
           Create/Manage Listings
         </a>
-      <%= select_tag "dashhboard_sort", options_for_select(sort_options, params[:sort]), 'aria-label': "Sort By" %>
+      <%= select_tag "dashboard_sort", options_for_select(sort_options, params[:sort]), 'aria-label': "Sort By" %>
       <% if @articles.any? {|article| article.archived } %>
         <%= link_to "Show archived", "javascript:;", id: "toggleArchivedLink" %>
       <% end %>