From 9cb4eea43e972a0d365fa5743696a4bacff58d25 Mon Sep 17 00:00:00 2001 From: Anna Buyanova Date: Thu, 6 Dec 2018 16:03:37 +0300 Subject: [PATCH] Update rubocop_todo (#1270) [ci skip] --- .rubocop_todo.yml | 280 ++++++++++++++++++++++++++++++++++++++++++---- 1 file changed, 256 insertions(+), 24 deletions(-) diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index 0b33d27b3..bbf2a5fbd 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -1,44 +1,60 @@ # This configuration was generated by # `rubocop --auto-gen-config` -# on 2018-10-02 23:35:16 +0300 using RuboCop version 0.59.2. +# on 2018-12-06 12:31:40 +0300 using RuboCop version 0.59.2. # The point is for the user to remove these configuration records # one by one as the offenses are removed from the code base. # Note that changes in the inspected code, or installation of new # versions of RuboCop, may require this file to be generated again. -# Offense count: 104 +# Offense count: 110 # Cop supports --auto-correct. Layout/EmptyLineAfterGuardClause: Enabled: false -# Offense count: 1 +# Offense count: 4 # Cop supports --auto-correct. Layout/EmptyLines: Exclude: - 'app/models/buffer_update.rb' + - 'app/models/mentor_relationship.rb' + - 'app/models/notification.rb' + - 'spec/requests/html_variants_spec.rb' -# Offense count: 1 +# Offense count: 3 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle. # SupportedStyles: empty_lines, no_empty_lines Layout/EmptyLinesAroundBlockBody: Exclude: - - 'config/routes.rb' + - 'spec/factories/podcasts.rb' + - 'spec/models/comment_spec.rb' + - 'spec/requests/html_variants_spec.rb' -# Offense count: 1 +# Offense count: 3 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle. # SupportedStyles: empty_lines, empty_lines_except_namespace, empty_lines_special, no_empty_lines, beginning_only, ending_only Layout/EmptyLinesAroundClassBody: Exclude: - 'app/models/buffer_update.rb' + - 'app/models/tag.rb' + - 'app/models/tag_adjustment.rb' -# Offense count: 1 +# Offense count: 5 # Cop supports --auto-correct. # Configuration parameters: AllowForAlignment, ForceEqualSignAlignment. Layout/ExtraSpacing: Exclude: - - 'app/models/article.rb' + - 'spec/factories/podcasts.rb' + - 'spec/models/tag_adjustment_spec.rb' + - 'spec/requests/tag_adjustments_spec.rb' + +# Offense count: 6 +# Cop supports --auto-correct. +# Configuration parameters: IndentationWidth. +# SupportedStyles: special_inside_parentheses, consistent, align_braces +Layout/IndentHash: + EnforcedStyle: consistent # Offense count: 1 # Cop supports --auto-correct. @@ -50,9 +66,31 @@ Layout/IndentationConsistency: # Offense count: 1 # Cop supports --auto-correct. +# Configuration parameters: Width, IgnoredPatterns. +Layout/IndentationWidth: + Exclude: + - 'lib/tasks/fetch.rake' + +# Offense count: 2 +# Cop supports --auto-correct. Layout/LeadingCommentSpace: Exclude: - 'app/controllers/stories_controller.rb' + - 'app/helpers/application_helper.rb' + +# Offense count: 1 +# Cop supports --auto-correct. +Layout/MultilineBlockLayout: + Exclude: + - 'spec/requests/internal_reactions_spec.rb' + +# Offense count: 1 +# Cop supports --auto-correct. +# Configuration parameters: EnforcedStyle. +# SupportedStyles: symmetrical, new_line, same_line +Layout/MultilineHashBraceLayout: + Exclude: + - 'spec/requests/articles_api_spec.rb' # Offense count: 3 # Cop supports --auto-correct. @@ -87,12 +125,62 @@ Layout/SpaceAroundEqualsInParameterDefault: Exclude: - 'app/models/buffer_update.rb' +# Offense count: 1 +# Cop supports --auto-correct. +# Configuration parameters: EnforcedStyle, EnforcedStyleForEmptyBraces. +# SupportedStyles: space, no_space +# SupportedStylesForEmptyBraces: space, no_space +Layout/SpaceBeforeBlockBraces: + Exclude: + - 'app/decorators/user_decorator.rb' + +# Offense count: 1 +# Cop supports --auto-correct. +Layout/SpaceBeforeComma: + Exclude: + - 'app/views/api/v0/users/index.json.jbuilder' + +# Offense count: 8 +# Cop supports --auto-correct. +# Configuration parameters: EnforcedStyle, EnforcedStyleForEmptyBraces, SpaceBeforeBlockParameters. +# SupportedStyles: space, no_space +# SupportedStylesForEmptyBraces: space, no_space +Layout/SpaceInsideBlockBraces: + Exclude: + - 'app/decorators/user_decorator.rb' + - 'spec/models/tag_adjustment_spec.rb' + - 'spec/requests/html_variants_spec.rb' + +# Offense count: 6 +# Cop supports --auto-correct. +# Configuration parameters: EnforcedStyle, EnforcedStyleForEmptyBraces. +# SupportedStyles: space, no_space, compact +# SupportedStylesForEmptyBraces: space, no_space +Layout/SpaceInsideHashLiteralBraces: + Exclude: + - 'app/models/notification.rb' + - 'spec/services/tag_adjustment_update_service_spec.rb' + +# Offense count: 2 +# Cop supports --auto-correct. +# Configuration parameters: EnforcedStyle. +# SupportedStyles: final_newline, final_blank_line +Layout/TrailingBlankLines: + Exclude: + - 'app/controllers/async_info_controller.rb' + - 'config/routes.rb' + # Offense count: 1 # Cop supports --auto-correct. # Configuration parameters: AllowInHeredoc. Layout/TrailingWhitespace: Exclude: - - 'app/mailers/notify_mailer.rb' + - 'app/controllers/follows_controller.rb' + +# Offense count: 1 +Lint/DuplicateMethods: + Exclude: + - 'app/models/article.rb' # Offense count: 4 Lint/IneffectiveAccessModifier: @@ -100,6 +188,12 @@ Lint/IneffectiveAccessModifier: - 'app/black_box/black_box.rb' - 'app/models/tweet.rb' +# Offense count: 1 +# Configuration parameters: MaximumRangeSize. +Lint/MissingCopEnableDirective: + Exclude: + - 'spec/requests/articles_api_spec.rb' + # Offense count: 2 # Configuration parameters: ContextCreatingMethods, MethodCreatingMethods. Lint/UselessAccessModifier: @@ -107,15 +201,20 @@ Lint/UselessAccessModifier: - 'app/black_box/black_box.rb' - 'app/models/tweet.rb' -# Offense count: 7 +# Offense count: 9 # Configuration parameters: CountComments, ExcludedMethods. # ExcludedMethods: refine Metrics/BlockLength: - Max: 62 + Max: 69 -# Offense count: 13 +# Offense count: 17 Metrics/PerceivedComplexity: - Max: 13 + Max: 15 + +# Offense count: 1 +Naming/ConstantName: + Exclude: + - 'app/liquid_tags/raw_tag.rb' # Offense count: 1 # Configuration parameters: MinNameLength, AllowNamesEndingInNumbers, AllowedNames, ForbiddenNames. @@ -124,16 +223,61 @@ Naming/UncommunicativeMethodParamName: Exclude: - 'app/models/message.rb' +# Offense count: 1 +# Cop supports --auto-correct. +RSpec/EmptyLineAfterExampleGroup: + Exclude: + - 'spec/requests/internal_reactions_spec.rb' + +# Offense count: 2 +# Cop supports --auto-correct. +RSpec/EmptyLineAfterFinalLet: + Exclude: + - 'spec/models/user_spec.rb' + - 'spec/policies/html_variant_policy_spec.rb' + # Offense count: 5 +# Cop supports --auto-correct. +RSpec/EmptyLineAfterHook: + Exclude: + - 'spec/requests/articles_api_spec.rb' + - 'spec/requests/internal_reactions_spec.rb' + - 'spec/requests/tag_adjustments_spec.rb' + +# Offense count: 17 # Configuration parameters: Max. RSpec/ExampleLength: Exclude: - 'spec/models/buffer_update_spec.rb' + - 'spec/models/html_variant_spec.rb' + - 'spec/models/mentor_relationship_spec.rb' - 'spec/models/message_spec.rb' - - 'spec/requests/analytics_spec.rb' + - 'spec/models/notification_spec.rb' + - 'spec/requests/dashboard_spec.rb' + - 'spec/requests/html_variants_spec.rb' - 'spec/requests/internal_buffer_updates_spec.rb' + - 'spec/requests/tag_adjustments_spec.rb' -# Offense count: 13 +# Offense count: 1 +# Cop supports --auto-correct. +# Configuration parameters: CustomTransform, IgnoredWords. +RSpec/ExampleWording: + Exclude: + - 'spec/labor/user_similarity_spec.rb' + +# Offense count: 1 +# Configuration parameters: CustomTransform, IgnoreMethods. +RSpec/FilePath: + Exclude: + - 'spec/liquid_tags/raw_tag_spec.rb' + +# Offense count: 1 +# Cop supports --auto-correct. +RSpec/HooksBeforeExamples: + Exclude: + - 'spec/models/tag_adjustment_spec.rb' + +# Offense count: 12 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle. # SupportedStyles: single_line_only, disallow @@ -142,19 +286,40 @@ RSpec/ImplicitSubject: - 'spec/models/feedback_message_spec.rb' - 'spec/policies/comment_policy_spec.rb' - 'spec/policies/organization_policy_spec.rb' - - 'spec/policies/user_policy_spec.rb' - 'spec/requests/dashboard_spec.rb' - 'spec/requests/registration_spec.rb' -# Offense count: 4 +# Offense count: 19 +# Configuration parameters: AssignmentOnly. +RSpec/InstanceVariable: + Exclude: + - 'spec/requests/articles_api_spec.rb' + - 'spec/requests/internal_reactions_spec.rb' + - 'spec/services/tag_adjustment_creation_service_spec.rb' + - 'spec/services/tag_adjustment_update_service_spec.rb' + +# Offense count: 6 +# Cop supports --auto-correct. +RSpec/LetBeforeExamples: + Exclude: + - 'spec/models/html_variant_spec.rb' + - 'spec/models/tag_adjustment_spec.rb' + +# Offense count: 16 # Configuration parameters: AggregateFailuresByDefault. RSpec/MultipleExpectations: Max: 6 -# Offense count: 2 +# Offense count: 6 RSpec/RepeatedDescription: Exclude: - 'spec/models/buffer_update_spec.rb' + - 'spec/requests/articles_api_spec.rb' + +# Offense count: 2 +RSpec/RepeatedExample: + Exclude: + - 'spec/requests/articles_api_spec.rb' # Offense count: 3 Security/Open: @@ -162,7 +327,28 @@ Security/Open: - 'app/labor/podcast_feed.rb' - 'app/labor/rss_reader.rb' -# Offense count: 14 +# Offense count: 1 +# Cop supports --auto-correct. +# Configuration parameters: EnforcedStyle, ProceduralMethods, FunctionalMethods, IgnoredMethods. +# SupportedStyles: line_count_based, semantic, braces_for_chaining +# ProceduralMethods: benchmark, bm, bmbm, create, each_with_object, measure, new, realtime, tap, with_object +# FunctionalMethods: let, let!, subject, watch +# IgnoredMethods: lambda, proc, it +Style/BlockDelimiters: + Exclude: + - 'spec/requests/internal_reactions_spec.rb' + +# Offense count: 5 +# Cop supports --auto-correct. +# Configuration parameters: EnforcedStyle. +# SupportedStyles: braces, no_braces, context_dependent +Style/BracesAroundHashParameters: + Exclude: + - 'app/controllers/tag_adjustments_controller.rb' + - 'spec/services/tag_adjustment_creation_service_spec.rb' + - 'spec/services/tag_adjustment_update_service_spec.rb' + +# Offense count: 15 # Cop supports --auto-correct. # Configuration parameters: AutoCorrect, EnforcedStyle. # SupportedStyles: nested, compact @@ -177,12 +363,22 @@ Style/ClassAndModuleChildren: - 'app/controllers/internal/dogfood_controller.rb' - 'app/controllers/internal/feedback_messages_controller.rb' - 'app/controllers/internal/members_controller.rb' + - 'app/controllers/internal/reactions_controller.rb' - 'app/controllers/internal/tags_controller.rb' - 'app/controllers/internal/users_controller.rb' - 'app/controllers/internal/welcome_controller.rb' - 'app/controllers/notifications/counts_controller.rb' - 'app/controllers/notifications/reads_controller.rb' +# Offense count: 2 +# Cop supports --auto-correct. +# Configuration parameters: EnforcedStyle, SingleLineConditionsOnly, IncludeTernaryExpressions. +# SupportedStyles: assign_to_condition, assign_inside_condition +Style/ConditionalAssignment: + Exclude: + - 'app/controllers/api/v0/articles_controller.rb' + - 'config/initializers/honeycomb.rb' + # Offense count: 1 Style/EvalWithLocation: Exclude: @@ -216,21 +412,57 @@ Style/RedundantSelf: # Offense count: 1 # Cop supports --auto-correct. +# Configuration parameters: ConvertCodeThatCanStartToReturnNil, Whitelist. +# Whitelist: present?, blank?, presence, try, try! +Style/SafeNavigation: + Exclude: + - 'app/models/follow.rb' + +# Offense count: 10 +# Cop supports --auto-correct. # Configuration parameters: EnforcedStyle, ConsistentQuotesInMultiline. # SupportedStyles: single_quotes, double_quotes Style/StringLiterals: Exclude: + - 'app/controllers/api/v0/articles_controller.rb' + - 'config/initializers/honeycomb.rb' - 'spec/models/buffer_update_spec.rb' + - 'spec/models/html_variant_spec.rb' + - 'spec/models/html_variant_success_spec.rb' + - 'spec/models/html_variant_trial_spec.rb' + - 'spec/models/tag_adjustment_spec.rb' + - 'tmp/user_visits_articles_by_tag_spec.rb' -# Offense count: 1 +# Offense count: 3 # Cop supports --auto-correct. -# Configuration parameters: EnforcedStyle, MinSize. +# Configuration parameters: . # SupportedStyles: percent, brackets Style/SymbolArray: - Exclude: - - 'config/routes.rb' + EnforcedStyle: percent + MinSize: 14 -# Offense count: 972 +# Offense count: 2 +# Cop supports --auto-correct. +# Configuration parameters: EnforcedStyleForMultiline. +# SupportedStylesForMultiline: comma, consistent_comma, no_comma +Style/TrailingCommaInArrayLiteral: + Exclude: + - 'Guardfile' + - 'app/lib/constants.rb' + +# Offense count: 7 +# Cop supports --auto-correct. +# Configuration parameters: EnforcedStyleForMultiline. +# SupportedStylesForMultiline: comma, consistent_comma, no_comma +Style/TrailingCommaInHashLiteral: + Exclude: + - 'app/dashboards/html_variant_dashboard.rb' + - 'spec/requests/articles_api_spec.rb' + - 'spec/requests/html_variant_successes_spec.rb' + - 'spec/requests/html_variant_trials_spec.rb' + - 'spec/requests/tag_adjustments_spec.rb' + +# Offense count: 1175 # Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns. # URISchemes: http, https Metrics/LineLength: