maverick/docbrown
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix broken Podcast liquid tag (#11511)

Browse source
This commit is contained in:
Mac Siri 2021-02-08 13:53:12 -05:00 • committed by GitHub
parent b2a5a8488d
commit 9bbc738dc3
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 9 additions and 45 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

40
app/views/podcast_episodes/_liquid.html.erb
View file

@ -19,42 +19,6 @@
optimizer_options: { crop: "fill" },
image_options: { class: "podcastliquidtag__podcastimage", id: "podcastimage-#{episode.slug}", alt: podcast.title }) %>
</div>
<div class="hidden-audio" id="hidden-audio-<%= episode.slug %>" style="display:none" data-episode="<%= episode.slug %>" data-podcast="<%= podcast.slug %>">
<audio id="audio" data-episode="<%= episode.slug %>" data-podcast="<%= podcast.slug %>">
<source src="<%= episode.media_url %>" type="audio/mpeg">
Your browser does not support the audio element.
</audio>
<div id="progressBar" class="audio-player-display">
<a href="/<%= podcast.slug + "/" + episode.slug %>">
<%= optimized_image_tag(episode.image_url || podcast.image_url,
optimizer_options: { crop: "fill", width: 420, height: 420 },
image_options: { id: "episode-profile-image", alt: episode.title }) %>
<img id="animated-bars" src="/assets/animated-bars.gif" alt="animated volume bars">
</a>
<span id="barPlayPause">
<img class="butt play-butt" src="/assets/playbutt.png" alt="play">
<img class="butt pause-butt" src="/assets/pausebutt.png" alt="pause">
</span>
<span id="volume">
<span id="volumeindicator" class="volume-icon-wrapper showing">
<span id="volbutt">
<%= image_tag("/assets/volume.png", alt: "volume", class: "icon-img", height: 16, width: 16) %>
</span>
<span class="range-wrapper">
<input type="range" name="points" id="volumeslider" value="50" min="0" max="100" data-show-value="true">
</span>
</span>
<span id="mutebutt" class="volume-icon-wrapper hidden">
<%= image_tag("/assets/volume-mute.png", alt: "mute", class: "icon-img", height: 16, width: 16) %>
</span>
<span class="speed" id="speed" data-speed=1>1x</span>
</span>
<span class="buffer-wrapper" id="bufferwrapper">
<span id="buffer"></span>
<span id="progress"></span>
<span id="time">initializing...</span>
<span id="closebutt">×</span>
</span>
</div>
</div>
<%= render "podcast_episodes/podcast_bar", podcast: podcast, episode: episode %>
</div>

12
app/views/podcast_episodes/_podcast_bar.html.erb
View file

@ -1,13 +1,13 @@
<div class="hidden-audio" id="hidden-audio-<%= @episode.slug %>" style="display:none" data-episode="<%= @episode.slug %>" data-podcast="<%= @podcast.slug %>">
<audio id="audio" data-episode="<%= @episode.slug %>" data-podcast="<%= @podcast.slug %>">
<source src="<%= @episode.media_url %>" type="audio/mpeg">
<div class="hidden-audio" id="hidden-audio-<%= episode.slug %>" style="display:none" data-episode="<%= episode.slug %>" data-podcast="<%= podcast.slug %>">
<audio id="audio" data-episode="<%= episode.slug %>" data-podcast="<%= podcast.slug %>">
<source src="<%= episode.media_url %>" type="audio/mpeg">
Your browser does not support the audio element.
</audio>
<div id="progressBar" class="audio-player-display">
<a href="/<%= @podcast.slug %>/<%= @episode.slug %>">
<%= optimized_image_tag(@episode.image_url || @podcast.image_url,
<a href="/<%= podcast.slug %>/<%= episode.slug %>">
<%= optimized_image_tag(episode.image_url || podcast.image_url,
optimizer_options: { crop: "fill", width: 420, height: 420 },
image_options: { id: "episode-profile-image", alt: @episode.title }) %>
image_options: { id: "episode-profile-image", alt: episode.title }) %>
<img id="animated-bars" src="<%= asset_path("animated-bars.gif") %>" alt="animated volume bars">
</a>
<span id="barPlayPause">

2
app/views/podcast_episodes/show.html.erb
View file

@ -108,4 +108,4 @@
</div>
</div>
<%= render "podcast_episodes/podcast_bar" %>
<%= render "podcast_episodes/podcast_bar", podcast: @podcast, episode: @episode %>