maverick/docbrown
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Eager load users before looping through messages (#4576)

Browse source 
* Eager load users before looping through messages

* Eager load users before looping through messages
This commit is contained in:
Molly Struve 2019-10-24 10:50:50 -05:00 • committed by Ben Halpern
parent e225847494
commit 9ac8223491
2 changed files with 4 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
app/controllers/chat_channels_controller.rb
View file

@ -16,7 +16,9 @@ class ChatChannelsController < ApplicationController
end
end
def show; end
def show
@chat_messages = @chat_channel.messages.includes(:user).order("created_at DESC").limit(50)
end
def create
authorize ChatChannel

2
app/views/chat_channels/show.json.jbuilder
View file

@ -1,4 +1,4 @@
json.messages @chat_channel.messages.order("created_at DESC").limit(50).reverse do |message|
json.messages @chat_messages.reverse do |message|
json.user_id message.user_id
json.username message.user.username
json.profile_image_url ProfileImage.new(message.user).get(90)