From 98cccdf0ef1850f32e6423e61c1d059a4792a20c Mon Sep 17 00:00:00 2001 From: Ben Halpern Date: Wed, 23 Aug 2023 12:35:07 -0400 Subject: [PATCH] Change MAX_TAG_LIST_SIZE for billboards to 25 (#19981) --- app/models/display_ad.rb | 2 +- spec/models/display_ad_spec.rb | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/app/models/display_ad.rb b/app/models/display_ad.rb index 585dc8c70..5e9e4a3b2 100644 --- a/app/models/display_ad.rb +++ b/app/models/display_ad.rb @@ -20,7 +20,7 @@ class DisplayAd < ApplicationRecord HOME_FEED_PLACEMENTS = %w[feed_first feed_second feed_third].freeze - MAX_TAG_LIST_SIZE = 10 + MAX_TAG_LIST_SIZE = 25 POST_WIDTH = 775 SIDEBAR_WIDTH = 350 LOW_IMPRESSION_COUNT = 1_000 diff --git a/spec/models/display_ad_spec.rb b/spec/models/display_ad_spec.rb index 294f5d34c..360e14b5d 100644 --- a/spec/models/display_ad_spec.rb +++ b/spec/models/display_ad_spec.rb @@ -245,12 +245,12 @@ RSpec.describe DisplayAd do describe ".validate_tag" do it "rejects more than 10 tags" do - eleven_tags = "one, two, three, four, five, six, seven, eight, nine, ten, eleven" + twenty_six_tags = Array.new(26) { SecureRandom.alphanumeric(8) }.join(", ") expect(build(:billboard, name: "This is a billboard", body_markdown: "Billboard Body", placement_area: "post_comments", - tag_list: eleven_tags).valid?).to be(false) + tag_list: twenty_six_tags).valid?).to be(false) end it "rejects tags with length > 30" do