maverick/docbrown
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Removed misleading information about sponsorships renewal (#6257)

Browse source 
* Removed misleading information about sponsorships renewal

* Change the spec not to rely on sponsorship auto-renewal info
This commit is contained in:
Anna Buianova 2020-02-28 01:55:12 +03:00 • committed by GitHub
parent 66bc6cf698
commit 946a94e560
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 1 additions and 16 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
app/views/partnerships/_form.html.erb
View file

@ -61,11 +61,6 @@
<h4>Sponsorship message/brand instructions:</h4>
<%= text_area_tag(:instructions, nil, placeholder: "Include brand guideline links and detailed instructions about the message you are trying to get across. DEV editors will use these guidelines contextually depending on sponsorship.") %>
<button>Subscribe for <%= Sponsorship::CREDITS[level] %> credits</button>
<p style="font-size: 0.88em;">
<em>
This subscription will renew every month with credits in your account. If there are no credits, 50 credits will be purchased at the appropriate price. You can cancel this automatic sponsorship subscription at any time.
</em>
</p>
<% end %>
<% end %>
<% elsif level == "tag" %>
@ -90,11 +85,6 @@
<% tag_names = Tag.where(supported: true).where.not(name: sponsored_tags).pluck(:name) %>
<%= select_tag "tag_name", options_for_select(tag_names) %>
<button>Sponsor Tag for <%= Sponsorship::CREDITS[:tag] %> credits</button>
<p style="font-size: 0.88em;">
<em>
This subscription will renew every month with credits in your account. If there are no credits, 50 credits will be purchased at the appropriate price. You can cancel this automatic sponsorship subscription at any time.
</em>
</p>
<% end %>
<%# NOTE: this currently can't be reached %>
<% elsif level == "media" %>
@ -124,11 +114,6 @@
<p style="font-size: 1.1em;">
You will be contacted by the DEV team within one day of signing up for this service.
</p>
<p style="font-size: 0.88em;">
<em>
This subscription will renew every month with credits in your account. If there are no credits, 50 credits will be purchased at the appropriate price. You can cancel this automatic sponsorship subscription at any time.
</em>
</p>
<% end %>
<% end %>
</div>

2
spec/requests/partnerships_spec.rb
View file

@ -56,7 +56,7 @@ RSpec.describe "Partnerships", type: :request do
OrganizationMembership.create(user_id: user.id, organization_id: organization.id, type_of_user: "admin")
Credit.add_to_org(organization, 100)
get "/partnerships/bronze-sponsor"
expect(response.body).to include("This subscription will renew every month")
expect(response.body).to include("Subscribe for #{Sponsorship::CREDITS[:bronze]} credits")
end
context "when sponsorship exists" do