From 93f73636c72a5006a5f246409e1824b384480eae Mon Sep 17 00:00:00 2001 From: Rajat Talesra Date: Thu, 2 Feb 2023 15:52:35 +0530 Subject: [PATCH] Post bootstrap changes - remove headings from admin.scss (#19019) * h1 and h2 design fixes * h2 redesign fixes * Removed incorrect code * Revert incorrect test code * h3 heading redesign * h4,h4,h5 headings redesign * Minor design fixes * Fixed all heading styles * Test case fix * Revert incorrect if condition * Revert incorrect if condition * Removed non required div --- app/assets/stylesheets/admin.scss | 40 ----------- .../articles/_individual_article.html.erb | 2 +- app/views/admin/articles/index.html.erb | 4 +- .../admin/badge_achievements/award.html.erb | 2 +- .../admin/badge_achievements/index.html.erb | 26 ++++--- app/views/admin/broadcasts/edit.html.erb | 2 +- app/views/admin/broadcasts/index.html.erb | 2 +- app/views/admin/broadcasts/new.html.erb | 2 +- app/views/admin/broadcasts/show.html.erb | 2 +- app/views/admin/consumer_apps/edit.html.erb | 2 +- app/views/admin/consumer_apps/index.html.erb | 2 +- app/views/admin/consumer_apps/new.html.erb | 2 +- app/views/admin/display_ads/edit.html.erb | 2 +- app/views/admin/display_ads/new.html.erb | 2 +- app/views/admin/email_messages/show.html.erb | 4 +- .../feedback_messages/_abuse_reports.html.erb | 2 +- .../_feedback_message.html.erb | 72 +++++++++---------- app/views/admin/html_variants/edit.html.erb | 2 +- app/views/admin/html_variants/new.html.erb | 2 +- app/views/admin/invitations/new.html.erb | 4 +- .../admin/listing_categories/edit.html.erb | 2 +- .../admin/listing_categories/new.html.erb | 2 +- app/views/admin/listings/edit.html.erb | 2 +- app/views/admin/listings/index.html.erb | 2 +- .../admin/navigation_links/index.html.erb | 4 +- .../admin/organizations/_activity.html.erb | 2 +- app/views/admin/organizations/show.html.erb | 6 +- app/views/admin/overview/_analytics.html.erb | 2 +- app/views/admin/pages/edit.html.erb | 2 +- app/views/admin/pages/index.html.erb | 4 +- app/views/admin/pages/new.html.erb | 2 +- app/views/admin/permissions/index.html.erb | 2 +- app/views/admin/podcasts/edit.html.erb | 2 +- .../admin/response_templates/edit.html.erb | 2 +- .../admin/response_templates/index.html.erb | 2 +- .../admin/response_templates/new.html.erb | 2 +- .../admin/shared/_image_uploader.html.erb | 2 +- app/views/admin/spaces/index.html.erb | 2 +- app/views/admin/tags/edit.html.erb | 10 ++- .../admin/tools/feed_playground.html.erb | 4 +- app/views/admin/tools/index.html.erb | 4 +- .../admin/users/index/_filters_modal.html.erb | 2 +- app/views/admin/users/new/show.html.erb | 2 +- .../admin/users/show/emails/_index.html.erb | 2 +- .../users/show/emails/_verification.html.erb | 2 +- .../admin/users/show/flags/_index.html.erb | 4 +- .../admin/users/show/notes/_index.html.erb | 2 +- .../users/show/overview/_credits.html.erb | 2 +- .../show/overview/_organizations.html.erb | 4 +- .../admin/users/show/overview/_roles.html.erb | 2 +- .../show/overview/_tag_moderation.html.erb | 2 +- .../admin/users/show/reports/_index.html.erb | 4 +- .../users/show/unpublish_logs/_index.html.erb | 2 +- app/views/admin/welcome/index.html.erb | 2 +- .../adminFlows/broadcasts/broadcasts.spec.js | 2 +- 55 files changed, 115 insertions(+), 159 deletions(-) diff --git a/app/assets/stylesheets/admin.scss b/app/assets/stylesheets/admin.scss index 0203fdf4f..6fab2b382 100644 --- a/app/assets/stylesheets/admin.scss +++ b/app/assets/stylesheets/admin.scss @@ -11,46 +11,6 @@ label { margin-bottom: 0 !important; } -h1 { - font-size: 2.5rem; - font-weight: 500; - line-height: 1.2; -} - -h2 { - font-size: 2rem; - font-weight: 500; - line-height: 1.2; -} - -h3 { - font-size: 1.75rem; - font-weight: 500; - line-height: 1.2; -} - -h4 { - font-size: 1.5rem; - font-weight: 500; - line-height: 1.2; -} - -h5 { - font-size: 1.25rem; - font-weight: 500; - line-height: 1.2; - margin-top: 0; - margin-bottom: 0.5rem; -} - -h6 { - font-size: 1rem; - font-weight: 500; - line-height: 1.2; - margin-top: 0; - margin-bottom: 0.5rem; -} - hr { margin-top: 1rem; margin-bottom: 1rem; diff --git a/app/views/admin/articles/_individual_article.html.erb b/app/views/admin/articles/_individual_article.html.erb index 75c1497e4..e165cc131 100644 --- a/app/views/admin/articles/_individual_article.html.erb +++ b/app/views/admin/articles/_individual_article.html.erb @@ -100,7 +100,7 @@ <% if article.user&.notes&.any? %>
-

<%= article.user&.notes&.size %> user notes

+

<%= article.user&.notes&.size %> user notes

View all
<% article.user&.notes&.last(3)&.each do |note| %> diff --git a/app/views/admin/articles/index.html.erb b/app/views/admin/articles/index.html.erb index a39788ed3..df4eaee72 100644 --- a/app/views/admin/articles/index.html.erb +++ b/app/views/admin/articles/index.html.erb @@ -33,14 +33,14 @@ <% if @pinned_article.present? %>
-

<%= crayons_icon_tag("pin.svg") %> Pinned Article

+

<%= crayons_icon_tag("pin.svg") %> Pinned Article

<%= render partial: "individual_article", locals: { article: @pinned_article } %>
<% end %> <% if @featured_articles.present? %>
-

Manually Featured Articles

+

Manually Featured Articles

<%= render partial: "individual_article", collection: @featured_articles, as: :article %>
<% end %> diff --git a/app/views/admin/badge_achievements/award.html.erb b/app/views/admin/badge_achievements/award.html.erb index 6f1874d63..6e5bb6796 100644 --- a/app/views/admin/badge_achievements/award.html.erb +++ b/app/views/admin/badge_achievements/award.html.erb @@ -1,5 +1,5 @@
-

Award Badges

+

Award Badges

<%= link_to "Back to Badge Achievements", admin_badge_achievements_path, class: "c-link c-link--block" %>
diff --git a/app/views/admin/badge_achievements/index.html.erb b/app/views/admin/badge_achievements/index.html.erb index 4d7012f02..2b9cc024a 100644 --- a/app/views/admin/badge_achievements/index.html.erb +++ b/app/views/admin/badge_achievements/index.html.erb @@ -23,7 +23,7 @@
- +
@@ -38,19 +38,17 @@ -
-
- - + + <% end %> diff --git a/app/views/admin/broadcasts/edit.html.erb b/app/views/admin/broadcasts/edit.html.erb index 5c38bd157..84f3038af 100644 --- a/app/views/admin/broadcasts/edit.html.erb +++ b/app/views/admin/broadcasts/edit.html.erb @@ -1,4 +1,4 @@ -

Edit broadcast:

+

Edit broadcast:

<%= form_for([:admin, @broadcast], method: :patch) do %> <%= render "form" %> diff --git a/app/views/admin/broadcasts/index.html.erb b/app/views/admin/broadcasts/index.html.erb index 3de10f081..ae8262486 100644 --- a/app/views/admin/broadcasts/index.html.erb +++ b/app/views/admin/broadcasts/index.html.erb @@ -1,5 +1,5 @@
-

Broadcasts

+

Broadcasts

Make a New Broadcast
diff --git a/app/views/admin/broadcasts/new.html.erb b/app/views/admin/broadcasts/new.html.erb index 1965522b0..8da079a59 100644 --- a/app/views/admin/broadcasts/new.html.erb +++ b/app/views/admin/broadcasts/new.html.erb @@ -1,4 +1,4 @@ -

Make a new broadcast:

+

Make a new broadcast:

<%= form_for([:admin, @broadcast], method: :post) do %> <%= render "form" %> diff --git a/app/views/admin/broadcasts/show.html.erb b/app/views/admin/broadcasts/show.html.erb index 5900631c2..1b95f61ce 100644 --- a/app/views/admin/broadcasts/show.html.erb +++ b/app/views/admin/broadcasts/show.html.erb @@ -5,7 +5,7 @@ data-confirmation-modal-title-value="Confirm changes" data-confirmation-modal-size-value="m">
-

<%= @broadcast.title %>

+

<%= @broadcast.title %>

<%= link_to "Edit", edit_admin_broadcast_path, class: "crayons-btn" %>
User ID<%= badge_achievement.user.id %> <%= badge_achievement.user.username %> <%= badge_achievement.badge.title %> - badge image - - - + badge image + + +
@@ -37,7 +37,7 @@
-

Email content

+

Email content

The content is previewed below without formatting

<%= @email.html_content.html_safe %> diff --git a/app/views/admin/feedback_messages/_abuse_reports.html.erb b/app/views/admin/feedback_messages/_abuse_reports.html.erb index 074d7d34b..187d5b20d 100644 --- a/app/views/admin/feedback_messages/_abuse_reports.html.erb +++ b/app/views/admin/feedback_messages/_abuse_reports.html.erb @@ -1,5 +1,5 @@
-

Abuse reports

+

Abuse reports