From 931d9169fdfd4df8c66ea5a58975a7bd9760bb8f Mon Sep 17 00:00:00 2001 From: Rafi Date: Fri, 22 Jan 2021 19:56:51 +0530 Subject: [PATCH] Fixing link focus (#12362) * Fixing link focus 1. Removing display content from link 2. Removing extra margin at the top of link 3. Adding before link * Extending crayon-fields and removing margin-top --- app/assets/stylesheets/preact/onboarding-modal.scss | 8 ++++---- app/javascript/onboarding/components/IntroSlide.jsx | 4 ++-- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/app/assets/stylesheets/preact/onboarding-modal.scss b/app/assets/stylesheets/preact/onboarding-modal.scss index 60de62c96..d71a14c4d 100644 --- a/app/assets/stylesheets/preact/onboarding-modal.scss +++ b/app/assets/stylesheets/preact/onboarding-modal.scss @@ -609,6 +609,10 @@ $onboarding-user-selected-hover: rgba(71, 85, 235, 0.2); @extend .crayons-field; @extend .crayons-field__label; + a { + margin-top: 0; + } + &:last-child { margin-bottom: 0; } @@ -650,10 +654,6 @@ $onboarding-user-selected-hover: rgba(71, 85, 235, 0.2); margin-bottom: 0; } - a { - display: contents; - } - input[type='checkbox'] { @extend .crayons-checkbox; margin-right: var(--su-2) !important; diff --git a/app/javascript/onboarding/components/IntroSlide.jsx b/app/javascript/onboarding/components/IntroSlide.jsx index 70ca09768..4233093f4 100644 --- a/app/javascript/onboarding/components/IntroSlide.jsx +++ b/app/javascript/onboarding/components/IntroSlide.jsx @@ -150,7 +150,7 @@ class IntroSlide extends Component { checked={checked_code_of_conduct} onChange={this.handleChange} /> - You agree to uphold our{' '} + You agree to uphold our  - You agree to our{' '} + You agree to our