Bump shoulda-matchers from 4.3.0 to 4.4.1 (#10077)

Gemfile

@@ -157,7 +157,7 @@ group :test do
   gem "pundit-matchers", "~> 1.6" # A set of RSpec matchers for testing Pundit authorisation policies
   gem "rspec-retry", "~> 0.6" # retry intermittently failing rspec examples
   gem "ruby-prof", "~> 1.4", require: false # ruby-prof is a fast code profiler for Ruby
-  gem "shoulda-matchers", "~> 4.3.0", require: false # Simple one-liner tests for common Rails functionality
+  gem "shoulda-matchers", "~> 4.4.1", require: false # Simple one-liner tests for common Rails functionality
   gem "simplecov", "0.17.1", require: false # Code coverage with a powerful configuration library and automatic merging of coverage across test suites
   gem "stackprof", "~> 0.2", require: false, platforms: :ruby # stackprof is a fast sampling profiler for ruby code, with cpu, wallclock and object allocation samplers
   gem "stripe-ruby-mock", "~> 3.0", require: "stripe_mock" # A drop-in library to test stripe without hitting their servers

Gemfile.lock

@@ -721,7 +721,7 @@ GEM
       rubyzip (>= 1.2.2)
     semantic_range (2.3.0)
     shellany (0.0.1)
-    shoulda-matchers (4.3.0)
+    shoulda-matchers (4.4.1)
       activesupport (>= 4.2.0)
     sidekiq (6.1.1)
       connection_pool (>= 2.2.2)
@@ -968,7 +968,7 @@ DEPENDENCIES
   s3_direct_upload (~> 0.1)
   sassc-rails (~> 2.1.2)
   sdoc (~> 1.1)
-  shoulda-matchers (~> 4.3.0)
+  shoulda-matchers (~> 4.4.1)
   sidekiq (~> 6.1.1)
   sidekiq-cron (~> 1.1)
   sidekiq-unique-jobs (~> 6.0.22)

app/models/organization.rb

@@ -11,7 +11,6 @@ class Organization < ApplicationRecord
 
   acts_as_followable
 
-  has_many :api_secrets, through: :users
   has_many :articles, dependent: :nullify
   has_many :collections, dependent: :nullify
   has_many :credits, dependent: :restrict_with_error

spec/models/organization_spec.rb

@@ -7,7 +7,6 @@ RSpec.describe Organization, type: :model do
     describe "builtin validations" do
       subject { organization }
 
-      it { is_expected.to have_many(:api_secrets).through(:users) }
       it { is_expected.to have_many(:articles).dependent(:nullify) }
       it { is_expected.to have_many(:collections).dependent(:nullify) }
       it { is_expected.to have_many(:credits).dependent(:restrict_with_error) }