maverick/docbrown
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Optimization: Convert tags/_main_feed and widget_list_item partial loads to collections (#12077)

Browse source 
* Optimization: Convert tags/_main_feed to load single stories as a collection

* render widget_list_item partial as a collection
This commit is contained in:
Molly Struve 2021-01-04 11:13:42 -06:00 • committed by GitHub
parent 1bad9dc698
commit 902570467a
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
app/views/articles/tags/_main_feed.html.erb
View file

@ -1,6 +1,4 @@
<% @stories.each_with_index do |story, i| %>
<%= render "articles/single_story", story: story, featured: false %>
<% end %>
<%= render partial: "articles/single_story", collection: @stories, as: :story, locals: { featured: false } %>
<% if @stories.size > 1 %>
<div class="placeholder-div"></div>
<% end %>

12
app/views/articles/tags/_sidebar_additional.html.erb
View file

@ -10,9 +10,7 @@
</header>
<div class="widget-body">
<div class="widget-link-list">
<% active_threads.each do |plucked_article| %>
<%= render "articles/widget_list_item", plucked_article: plucked_article, show_comment_count: true %>
<% end %>
<%= render partial: "articles/widget_list_item", collection: active_threads, as: :plucked_article, locals: { show_comment_count: true } %>
</div>
</div>
</div>
@ -31,9 +29,7 @@
</header>
<div class="widget-body">
<div class="widget-link-list">
<% boostable_posts.each do |plucked_article| %>
<%= render "articles/widget_list_item", plucked_article: plucked_article, show_comment_count: false %>
<% end %>
<%= render partial: "articles/widget_list_item", collection: boostable_posts, as: :plucked_article, locals: { show_comment_count: false } %>
</div>
</div>
</div>
@ -46,9 +42,7 @@
</header>
<div class="widget-body">
<div class="widget-link-list">
<% recent_preamble_optimized_posts.each do |plucked_article| %>
<%= render "articles/widget_list_item", plucked_article: plucked_article, show_comment_count: false %>
<% end %>
<%= render partial: "articles/widget_list_item", collection: recent_preamble_optimized_posts, as: :plucked_article, locals: { show_comment_count: false } %>
</div>
</div>
</div>