Routine rubocop fixes (#8028)

.rubocop.yml

@@ -121,6 +121,10 @@ Lint/AmbiguousBlockAssociation:
   Exclude:
     - "spec/**/*"
 
+Lint/DeprecatedOpenSSLConstant:
+  Description: "Don't use algorithm constants for `OpenSSL::Cipher` and `OpenSSL::Digest`."
+  Enabled: true
+
 # Lint/HeredocMethodCallPosition:
 #   Description: >-
 #                  Checks for the ordering of a method call where

.rubocop_todo.yml

@@ -6,31 +6,30 @@ require:
 
 # This configuration was generated by
 # `rubocop --auto-gen-config`
-# on 2020-05-15 16:11:31 +0200 using RuboCop version 0.83.0.
+# on 2020-05-22 10:44:28 +0200 using RuboCop version 0.84.0.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
 # versions of RuboCop, may require this file to be generated again.
 
-# Offense count: 266
+# Offense count: 268
 # Configuration parameters: IgnoredMethods.
 Metrics/AbcSize:
   Max: 64
 
-# Offense count: 6
+# Offense count: 7
 # Configuration parameters: CountComments, ExcludedMethods.
 # ExcludedMethods: refine
 Metrics/BlockLength:
   Max: 53
 
-# Offense count: 10
+# Offense count: 8
 Performance/OpenStruct:
   Exclude:
     - 'app/models/article.rb'
     - 'app/models/organization.rb'
     - 'app/services/aws/fake_client.rb'
     - 'app/services/notifications/reactions/send.rb'
-    - 'spec/labor/badge_rewarder_spec.rb'
     - 'spec/models/github_repo_spec.rb'
     - 'spec/requests/github_repos_spec.rb'
 
@@ -41,9 +40,9 @@ RSpec/ExampleLength:
     - 'spec/models/comment_spec.rb'
     - 'spec/requests/display_ad_events_spec.rb'
 
-# Offense count: 872
+# Offense count: 855
 RSpec/MultipleExpectations:
-  Max: 10
+  Max: 12
 
 # Offense count: 1
 RSpec/SubjectStub:
@@ -75,11 +74,23 @@ Rails/OutputSafety:
     - 'app/models/display_ad.rb'
     - 'app/models/message.rb'
 
-# Offense count: 26
+# Offense count: 17
 # Configuration parameters: Include.
 # Include: app/models/**/*.rb
 Rails/UniqueValidationWithoutIndex:
-  Enabled: false
+  Exclude:
+    - 'app/models/article.rb'
+    - 'app/models/badge_achievement.rb'
+    - 'app/models/chat_channel.rb'
+    - 'app/models/chat_channel_membership.rb'
+    - 'app/models/collection.rb'
+    - 'app/models/comment.rb'
+    - 'app/models/data_update_script.rb'
+    - 'app/models/follow.rb'
+    - 'app/models/github_repo.rb'
+    - 'app/models/notification.rb'
+    - 'app/models/organization.rb'
+    - 'app/models/response_template.rb'
 
 # Offense count: 33
 # Cop supports --auto-correct.
@@ -95,7 +106,7 @@ Style/SingleLineBlockParams:
   Exclude:
     - 'app/labor/markdown_fixer.rb'
 
-# Offense count: 5168
+# Offense count: 534
 # Cop supports --auto-correct.
 # Configuration parameters: AutoCorrect, AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns.
 # URISchemes: http, https

spec/requests/stories_index_spec.rb

@@ -200,7 +200,6 @@ RSpec.describe "StoriesIndex", type: :request do
         get "/"
         expect(response.body).not_to include('<a href="https://campaign-lander.com"')
       end
-
     end
   end