diff --git a/app/controllers/admin/articles_controller.rb b/app/controllers/admin/articles_controller.rb index d380e1034..bdd196609 100644 --- a/app/controllers/admin/articles_controller.rb +++ b/app/controllers/admin/articles_controller.rb @@ -18,8 +18,6 @@ module Admin published_at].freeze def index - @pinned_article = PinnedArticle.get - case params[:state] when /top-/ months_ago = params[:state].split("-")[1].to_i.months.ago @@ -30,6 +28,9 @@ module Admin @articles = articles_mixed @featured_articles = articles_featured end + + @pinned_article = PinnedArticle.get + @articles = @articles.where.not(id: @pinned_article) if @pinned_article end def show @@ -55,7 +56,7 @@ module Admin respond_to do |format| format.html do - flash[:success] = I18n.t("admin.articles_controller.pinned") + flash[:danger] = I18n.t("admin.articles_controller.unpinned") redirect_to admin_article_path(article.id) end format.js do diff --git a/app/javascript/admin/controllers/article_controller.js b/app/javascript/admin/controllers/article_controller.js index 7c6f041c8..fb59b87de 100644 --- a/app/javascript/admin/controllers/article_controller.js +++ b/app/javascript/admin/controllers/article_controller.js @@ -6,7 +6,6 @@ export default class ArticleController extends Controller { 'featuredNumber', 'cardBody', 'pinnedCheckbox', - 'unpinButton', ]; static values = { id: Number, pinPath: String }; @@ -74,11 +73,15 @@ export default class ArticleController extends Controller { } } - ajaxSuccess(event) { - if (event.target !== this.unpinButtonTarget) { - return; - } + async unpinArticle(event) { + const unpinArticleForm = event.target; + // We dont want to submit the pin form here. + event.preventDefault(); + unpinArticleForm.submit(); + } + + ajaxSuccess(event) { // Replace the current Article HTML with the HTML sent by the server const newArticle = document.createElement('div'); diff --git a/app/views/admin/articles/_individual_article.html.erb b/app/views/admin/articles/_individual_article.html.erb index 8324f5047..6bc234c22 100644 --- a/app/views/admin/articles/_individual_article.html.erb +++ b/app/views/admin/articles/_individual_article.html.erb @@ -73,14 +73,14 @@