From 88a3b573eaee1ce67f28d9aaaa00dc10ecc5c7a0 Mon Sep 17 00:00:00 2001 From: ludwiczakpawel Date: Mon, 25 Oct 2021 21:41:29 +0200 Subject: [PATCH] Page headers unified (#15158) * fix; remove the bottom 100% * dashboard * fixes + magic border-radius * everything * fix * fix * spec * split PRs * Update app/assets/stylesheets/views/listings.scss Co-authored-by: Ridhwana Co-authored-by: Ridhwana --- app/assets/stylesheets/base/layout.scss | 40 ++++++- .../stylesheets/components/headers.scss | 16 +-- app/assets/stylesheets/views/listings.scss | 3 +- .../listings/components/ListingFilters.jsx | 2 +- .../components/ListingFiltersCategories.jsx | 2 +- .../components/ListingFiltersTags.jsx | 2 +- .../listings/components/SelectedTags.jsx | 2 +- .../readingList/components/ItemListItem.jsx | 13 +- .../readingList/components/TagList.jsx | 8 +- app/javascript/readingList/readingList.jsx | 34 +++--- app/views/collections/index.html.erb | 2 +- app/views/collections/show.html.erb | 2 +- app/views/dashboards/_actions_mobile.html.erb | 2 +- app/views/dashboards/_analytics.html.erb | 10 +- .../_dashboard_article_row.html.erb | 2 +- app/views/dashboards/followers.html.erb | 73 ++++++------ .../following_organizations.html.erb | 71 ++++++----- .../dashboards/following_podcasts.html.erb | 70 ++++++----- app/views/dashboards/following_tags.html.erb | 95 +++++++-------- app/views/dashboards/following_users.html.erb | 76 ++++++------ app/views/dashboards/show.html.erb | 112 +++++++++--------- app/views/dashboards/subscriptions.html.erb | 2 +- app/views/listings/index.html.erb | 2 +- .../moderations/_mod_sidebar_left.html.erb | 2 +- app/views/notifications/_nav_menu.html.erb | 2 +- app/views/notifications/index.html.erb | 11 +- app/views/podcast_episodes/index.html.erb | 6 +- .../stories/articles_search/index.html.erb | 48 ++++---- app/views/tags/index.html.erb | 10 +- app/views/users/edit.html.erb | 44 +++---- .../dashboards/user_visits_dashboard_spec.rb | 4 +- 31 files changed, 398 insertions(+), 370 deletions(-) diff --git a/app/assets/stylesheets/base/layout.scss b/app/assets/stylesheets/base/layout.scss index 3df8c960d..8802fd019 100644 --- a/app/assets/stylesheets/base/layout.scss +++ b/app/assets/stylesheets/base/layout.scss @@ -32,7 +32,7 @@ max-width: var(--site-width); margin: 0 auto; display: grid; - grid-gap: var(--layout-gap); + gap: var(--layout-gap); grid-template-columns: var(--layout); padding: var(--layout-padding); @@ -284,3 +284,41 @@ .text-padding { padding: var(--content-padding-y) var(--content-padding-x); } + +.crayons-page-header { + --layout-padding: var(--su-3); + + @media (min-width: $breakpoint-l) { + --layout-padding: var(--su-4); + } + + padding: var(--layout-padding); + max-width: var(--site-width); + width: 100%; + margin: 0 auto; + display: flex; + align-items: center; + justify-content: space-between; + + @media (min-width: $breakpoint-m) { + min-height: unset; + } +} + +.crayons-layout--header-inside { + --header-span: 1 / span 1; + &.crayons-layout--2-cols { + --header-span: 1 / span 2; + } + grid-template-rows: min-content 1fr; + row-gap: 0; + + @media (min-width: $breakpoint-m) { + row-gap: var(--layout-gap); + + .crayons-page-header { + --layout-padding: 0; + grid-column: var(--header-span); + } + } +} diff --git a/app/assets/stylesheets/components/headers.scss b/app/assets/stylesheets/components/headers.scss index a1b5f6f09..115ab4e83 100644 --- a/app/assets/stylesheets/components/headers.scss +++ b/app/assets/stylesheets/components/headers.scss @@ -1,24 +1,24 @@ @import '../config/import'; -.crayons-page-header { - padding: var(--su-3) var(--su-3) var(--su-1); - - @media (min-width: $breakpoint-m) { - padding: 0; - } -} - .crayons-title, .crayons-subtitle-1, .crayons-subtitle-2, .crayons-subtitle-3 { font-weight: var(--fw-bold); color: var(--base-90); + line-height: var(--lh-tight); + + @media (min-width: $breakpoint-s) { + line-height: var(--lh-base); + } } .crayons-title { color: var(--base-100); font-size: var(--fs-2xl); + display: inline-flex; + min-height: 40px; + align-items: center; @media (min-width: $breakpoint-s) { font-size: var(--fs-3xl); diff --git a/app/assets/stylesheets/views/listings.scss b/app/assets/stylesheets/views/listings.scss index 1c6fc8357..8e469ab4a 100644 --- a/app/assets/stylesheets/views/listings.scss +++ b/app/assets/stylesheets/views/listings.scss @@ -3,9 +3,10 @@ .listings-columns { margin-bottom: var(--su-6); + display: grid; + gap: var(--su-2); @media (min-width: $breakpoint-m) { - display: grid; grid-gap: var(--su-4); grid-template-columns: repeat(auto-fill, minmax(360px, 1fr)); } diff --git a/app/javascript/listings/components/ListingFilters.jsx b/app/javascript/listings/components/ListingFilters.jsx index 1ea8e4561..498efeea6 100644 --- a/app/javascript/listings/components/ListingFilters.jsx +++ b/app/javascript/listings/components/ListingFilters.jsx @@ -16,7 +16,7 @@ export const ListingFilters = ({ query, }) => { return ( -
+
( -
+