From 86d8128dd9883b273d165887bc6647b035849e69 Mon Sep 17 00:00:00 2001 From: Mario See Date: Thu, 9 May 2019 19:33:59 -0400 Subject: [PATCH] Utilize ERB template in CodepenTag (#2748) [ci skip] --- app/liquid_tags/codepen_tag.rb | 21 +++++++++---------- app/views/liquids/_codepen.html.erb | 8 +++++++ .../codepen_liquid_tag.approved.html | 3 ++- 3 files changed, 20 insertions(+), 12 deletions(-) create mode 100644 app/views/liquids/_codepen.html.erb diff --git a/app/liquid_tags/codepen_tag.rb b/app/liquid_tags/codepen_tag.rb index e99b6edbf..4794031e7 100644 --- a/app/liquid_tags/codepen_tag.rb +++ b/app/liquid_tags/codepen_tag.rb @@ -1,22 +1,21 @@ class CodepenTag < LiquidTagBase + PARTIAL = "liquids/codepen".freeze + def initialize(tag_name, link, tokens) super @link = parse_link(link) @build_options = parse_options(link) - @height = 600 end def render(_context) - html = <<-HTML - - HTML - finalize_html(html) + ActionController::Base.new.render_to_string( + partial: PARTIAL, + locals: { + link: @link, + height: 600, + build_options: @build_options + }, + ) end private diff --git a/app/views/liquids/_codepen.html.erb b/app/views/liquids/_codepen.html.erb new file mode 100644 index 000000000..37cbbc490 --- /dev/null +++ b/app/views/liquids/_codepen.html.erb @@ -0,0 +1,8 @@ + diff --git a/spec/support/fixtures/approvals/codepen_liquid_tag.approved.html b/spec/support/fixtures/approvals/codepen_liquid_tag.approved.html index 9e00af07d..0263566fe 100644 --- a/spec/support/fixtures/approvals/codepen_liquid_tag.approved.html +++ b/spec/support/fixtures/approvals/codepen_liquid_tag.approved.html @@ -1,6 +1,7 @@ - +