maverick/docbrown
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Remove migrated job to bust comment cache (#5548)

Browse source
This commit is contained in:
Asha Balasubramaniam 2020-01-17 14:21:39 -05:00 • committed by Mac Siri
parent a1968f926d
commit 80aa2d51cf
2 changed files with 0 additions and 84 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
app/jobs/comments/bust_cache_job.rb
View file

@ -1,15 +0,0 @@
module Comments
class BustCacheJob < ApplicationJob
queue_as :comments_bust_cache
def perform(comment_id, service = EdgeCache::Commentable::Bust)
comment = Comment.find_by(id: comment_id)
return unless comment&.commentable
comment.purge
comment.commentable.purge
service.call(comment.commentable)
end
end
end

69
spec/jobs/comments/bust_cache_job_spec.rb
View file

@ -1,69 +0,0 @@
require "rails_helper"
RSpec.describe Comments::BustCacheJob, type: :job do
include_examples "#enqueues_job", "comments_bust_cache", 5
describe "#perform_now" do
let(:edge_cache_commentable_bust_service) { double }
before do
allow(edge_cache_commentable_bust_service).to receive(:call)
end
context "with comment" do
let(:comment) { double }
let(:comment_id) { 1 }
let(:commentable) { double }
before do
allow(comment).to receive(:commentable).and_return(commentable)
allow(comment).to receive(:purge)
allow(commentable).to receive(:purge)
allow(Comment).to receive(:find_by).with(id: comment_id).and_return(comment)
end
it "calls the service" do
described_class.perform_now(comment_id, edge_cache_commentable_bust_service)
expect(edge_cache_commentable_bust_service).to have_received(:call).with(comment.commentable).once
end
it "does not call purge on comment when commentable is not available" do
allow(comment).to receive(:commentable).and_return(nil)
described_class.perform_now(comment_id, edge_cache_commentable_bust_service)
expect(comment).not_to have_received(:purge)
expect(commentable).not_to have_received(:purge)
end
it "does not call purge on commentable when commentable is not available" do
allow(comment).to receive(:commentable).and_return(nil)
described_class.perform_now(comment_id, edge_cache_commentable_bust_service)
expect(commentable).not_to have_received(:purge)
end
it "does not call the service when commentable is not available" do
allow(comment).to receive(:commentable).and_return(nil)
described_class.perform_now(comment_id, edge_cache_commentable_bust_service)
expect(edge_cache_commentable_bust_service).not_to have_received(:call)
end
end
context "without comment" do
it "does not break" do
expect { described_class.perform_now(nil, edge_cache_commentable_bust_service) }.not_to raise_error
end
it "doesn't call the service" do
described_class.perform_now(nil, edge_cache_commentable_bust_service)
expect(edge_cache_commentable_bust_service).not_to have_received(:call)
end
end
end
end